Skip to content

Commit

Permalink
[PATCH] remove kernel/kthread.c:kthread_stop_sem()
Browse files Browse the repository at this point in the history
Remove the now-unneeded kthread_stop_sem().

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Adrian Bunk authored and Linus Torvalds committed Jul 15, 2006
1 parent 098c5ee commit 52e92e5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 23 deletions.
1 change: 0 additions & 1 deletion include/linux/kthread.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ struct task_struct *kthread_create(int (*threadfn)(void *data),

void kthread_bind(struct task_struct *k, unsigned int cpu);
int kthread_stop(struct task_struct *k);
int kthread_stop_sem(struct task_struct *k, struct semaphore *s);
int kthread_should_stop(void);

#endif /* _LINUX_KTHREAD_H */
24 changes: 2 additions & 22 deletions kernel/kthread.c
Original file line number Diff line number Diff line change
Expand Up @@ -215,23 +215,6 @@ EXPORT_SYMBOL(kthread_bind);
* was never called.
*/
int kthread_stop(struct task_struct *k)
{
return kthread_stop_sem(k, NULL);
}
EXPORT_SYMBOL(kthread_stop);

/**
* kthread_stop_sem - stop a thread created by kthread_create().
* @k: thread created by kthread_create().
* @s: semaphore that @k waits on while idle.
*
* Does essentially the same thing as kthread_stop() above, but wakes
* @k by calling up(@s).
*
* Returns the result of threadfn(), or %-EINTR if wake_up_process()
* was never called.
*/
int kthread_stop_sem(struct task_struct *k, struct semaphore *s)
{
int ret;

Expand All @@ -246,10 +229,7 @@ int kthread_stop_sem(struct task_struct *k, struct semaphore *s)

/* Now set kthread_should_stop() to true, and wake it up. */
kthread_stop_info.k = k;
if (s)
up(s);
else
wake_up_process(k);
wake_up_process(k);
put_task_struct(k);

/* Once it dies, reset stop ptr, gather result and we're done. */
Expand All @@ -260,7 +240,7 @@ int kthread_stop_sem(struct task_struct *k, struct semaphore *s)

return ret;
}
EXPORT_SYMBOL(kthread_stop_sem);
EXPORT_SYMBOL(kthread_stop);

static __init int helper_init(void)
{
Expand Down

0 comments on commit 52e92e5

Please sign in to comment.