Skip to content

Commit

Permalink
[GFS2] gfs2_set_flags double locking patch
Browse files Browse the repository at this point in the history
traced the "umount hang due to spurious glock" issue that I was having
with gfs2meta. It's in the do_gfs2_set_flags function, which does a
gfs2_holder_init as well as a gfs2_glock_nq_init (increases ref count by
2 instead of 1).

Signed-off-by: Abhijith Das <adas@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
  • Loading branch information
Abhijith Das authored and Steven Whitehouse committed Jul 21, 2006
1 parent c5921fd commit 52f341c
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions fs/gfs2/ops_file.c
Original file line number Diff line number Diff line change
Expand Up @@ -608,12 +608,9 @@ static int do_gfs2_set_flags(struct file *filp, u32 reqflags, u32 mask)
int error;
u32 new_flags, flags;

gfs2_holder_init(ip->i_gl, LM_ST_EXCLUSIVE, 0, &gh);
error = gfs2_glock_nq_init(ip->i_gl, LM_ST_EXCLUSIVE, 0, &gh);
if (error) {
gfs2_holder_uninit(&gh);
if (error)
return error;
}

flags = ip->i_di.di_flags;
new_flags = (flags & ~mask) | (reqflags & mask);
Expand Down

0 comments on commit 52f341c

Please sign in to comment.