Skip to content

Commit

Permalink
[SCSI] for_each_possible_cpu: scsi
Browse files Browse the repository at this point in the history
for_each_cpu() actually iterates across all possible CPUs.  We've had mistakes
in the past where people were using for_each_cpu() where they should have been
iterating across only online or present CPUs.  This is inefficient and
possibly buggy.

We're renaming for_each_cpu() to for_each_possible_cpu() to avoid this in the
future.

This patch replaces for_each_cpu with for_each_possible_cpu.

Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
  • Loading branch information
KAMEZAWA Hiroyuki authored and James Bottomley committed Apr 13, 2006
1 parent ac05165 commit 530bba6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/scsi/scsi.c
Original file line number Diff line number Diff line change
Expand Up @@ -1243,7 +1243,7 @@ static int __init init_scsi(void)
if (error)
goto cleanup_sysctl;

for_each_cpu(i)
for_each_possible_cpu(i)
INIT_LIST_HEAD(&per_cpu(scsi_done_q, i));

printk(KERN_NOTICE "SCSI subsystem initialized\n");
Expand Down

0 comments on commit 530bba6

Please sign in to comment.