Skip to content

Commit

Permalink
V4L/DVB (6578): dvb-usb: make some debug vars static
Browse files Browse the repository at this point in the history
This patch makes some needlessly global debug variables static.

opera1.h became so small that I removed it.

Signed-off-by: Adrian Bunk <bunk@kernel.org>
Reviewed-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
  • Loading branch information
Adrian Bunk authored and Mauro Carvalho Chehab committed Jan 25, 2008
1 parent f760d61 commit 53133af
Show file tree
Hide file tree
Showing 8 changed files with 14 additions and 27 deletions.
5 changes: 4 additions & 1 deletion drivers/media/dvb/dvb-usb/cxusb.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,12 @@
#include "zl10353.h"

/* debug */
int dvb_usb_cxusb_debug;
static int dvb_usb_cxusb_debug;
module_param_named(debug, dvb_usb_cxusb_debug, int, 0644);
MODULE_PARM_DESC(debug, "set debugging level (1=rc (or-able))." DVB_USB_DEBUG_STATUS);
#define deb_info(args...) dprintk(dvb_usb_cxusb_debug,0x01,args)
#define deb_i2c(args...) if (d->udev->descriptor.idVendor == USB_VID_MEDION) \
dprintk(dvb_usb_cxusb_debug,0x01,args)

static int cxusb_ctrl_msg(struct dvb_usb_device *d,
u8 cmd, u8 *wbuf, int wlen, u8 *rbuf, int rlen)
Expand Down
5 changes: 0 additions & 5 deletions drivers/media/dvb/dvb-usb/cxusb.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,6 @@
#define DVB_USB_LOG_PREFIX "cxusb"
#include "dvb-usb.h"

extern int dvb_usb_cxusb_debug;
#define deb_info(args...) dprintk(dvb_usb_cxusb_debug,0x01,args)
#define deb_i2c(args...) if (d->udev->descriptor.idVendor == USB_VID_MEDION) \
dprintk(dvb_usb_cxusb_debug,0x01,args)

/* usb commands - some of it are guesses, don't have a reference yet */
#define CMD_I2C_WRITE 0x08
#define CMD_I2C_READ 0x09
Expand Down
3 changes: 2 additions & 1 deletion drivers/media/dvb/dvb-usb/digitv.c
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,10 @@
#include "nxt6000.h"

/* debug */
int dvb_usb_digitv_debug;
static int dvb_usb_digitv_debug;
module_param_named(debug,dvb_usb_digitv_debug, int, 0644);
MODULE_PARM_DESC(debug, "set debugging level (1=rc (or-able))." DVB_USB_DEBUG_STATUS);
#define deb_rc(args...) dprintk(dvb_usb_digitv_debug,0x01,args)

static int digitv_ctrl_msg(struct dvb_usb_device *d,
u8 cmd, u8 vv, u8 *wbuf, int wlen, u8 *rbuf, int rlen)
Expand Down
3 changes: 0 additions & 3 deletions drivers/media/dvb/dvb-usb/digitv.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ struct digitv_state {
int is_nxt6000;
};

extern int dvb_usb_digitv_debug;
#define deb_rc(args...) dprintk(dvb_usb_digitv_debug,0x01,args)

/* protocol (from usblogging and the SDK:
*
* Always 7 bytes bulk message(s) for controlling
Expand Down
6 changes: 4 additions & 2 deletions drivers/media/dvb/dvb-usb/opera1.c
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@
* see Documentation/dvb/README.dvb-usb for more information
*/

#include "opera1.h"
#define DVB_USB_LOG_PREFIX "opera"

#include "dvb-usb.h"
#include "stv0299.h"

#define OPERA_READ_MSG 0
Expand Down Expand Up @@ -38,7 +40,7 @@ struct opera_rc_keys {
u32 event;
};

int dvb_usb_opera1_debug;
static int dvb_usb_opera1_debug;
module_param_named(debug, dvb_usb_opera1_debug, int, 0644);
MODULE_PARM_DESC(debug,
"set debugging level (1=info,xfer=2,pll=4,ts=8,err=16,rc=32,fw=64 (or-able))."
Expand Down
9 changes: 0 additions & 9 deletions drivers/media/dvb/dvb-usb/opera1.h

This file was deleted.

5 changes: 4 additions & 1 deletion drivers/media/dvb/dvb-usb/vp7045.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,12 @@
#include "vp7045.h"

/* debug */
int dvb_usb_vp7045_debug;
static int dvb_usb_vp7045_debug;
module_param_named(debug,dvb_usb_vp7045_debug, int, 0644);
MODULE_PARM_DESC(debug, "set debugging level (1=info,xfer=2,rc=4 (or-able))." DVB_USB_DEBUG_STATUS);
#define deb_info(args...) dprintk(dvb_usb_vp7045_debug,0x01,args)
#define deb_xfer(args...) dprintk(dvb_usb_vp7045_debug,0x02,args)
#define deb_rc(args...) dprintk(dvb_usb_vp7045_debug,0x04,args)

int vp7045_usb_op(struct dvb_usb_device *d, u8 cmd, u8 *out, int outlen, u8 *in, int inlen, int msec)
{
Expand Down
5 changes: 0 additions & 5 deletions drivers/media/dvb/dvb-usb/vp7045.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,6 @@
#define DVB_USB_LOG_PREFIX "vp7045"
#include "dvb-usb.h"

extern int dvb_usb_vp7045_debug;
#define deb_info(args...) dprintk(dvb_usb_vp7045_debug,0x01,args)
#define deb_xfer(args...) dprintk(dvb_usb_vp7045_debug,0x02,args)
#define deb_rc(args...) dprintk(dvb_usb_vp7045_debug,0x04,args)

/* vp7045 commands */

/* Twinhan Vendor requests */
Expand Down

0 comments on commit 53133af

Please sign in to comment.