Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 164300
b: refs/heads/master
c: 8312136
h: refs/heads/master
v: v3
  • Loading branch information
Cyrill Gorcunov authored and Ingo Molnar committed Sep 20, 2009
1 parent 71e0536 commit 532dd34
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 4 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: efc8f7419ea0a97c38d0b80785c8c3d9ab8a4872
refs/heads/master: 8312136fa8b0a3ec7323bbb1a46be8c0c26e994e
13 changes: 13 additions & 0 deletions trunk/arch/x86/include/asm/apic.h
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,19 @@ static inline void default_inquire_remote_apic(int apicid)
__inquire_remote_apic(apicid);
}

/*
* With 82489DX we can't rely on apic feature bit
* retrieved via cpuid but still have to deal with
* such an apic chip so we assume that SMP configuration
* is found from MP table (64bit case uses ACPI mostly
* which set smp presence flag as well so we are safe
* to use this helper too).
*/
static inline bool apic_from_smp_config(void)
{
return smp_found_config && !disable_apic;
}

/*
* Basic functions accessing APICs.
*/
Expand Down
2 changes: 1 addition & 1 deletion trunk/arch/x86/kernel/apic/apic.c
Original file line number Diff line number Diff line change
Expand Up @@ -978,7 +978,7 @@ void lapic_shutdown(void)
{
unsigned long flags;

if (!cpu_has_apic)
if (!cpu_has_apic && !apic_from_smp_config())
return;

local_irq_save(flags);
Expand Down
4 changes: 2 additions & 2 deletions trunk/arch/x86/kernel/apic/io_apic.c
Original file line number Diff line number Diff line change
Expand Up @@ -1863,7 +1863,7 @@ __apicdebuginit(int) print_all_ICs(void)
print_PIC();

/* don't print out if apic is not there */
if (!cpu_has_apic || disable_apic)
if (!cpu_has_apic && !apic_from_smp_config())
return 0;

print_all_local_APICs();
Expand Down Expand Up @@ -1981,7 +1981,7 @@ void disable_IO_APIC(void)
/*
* Use virtual wire A mode when interrupt remapping is enabled.
*/
if (cpu_has_apic)
if (cpu_has_apic || apic_from_smp_config())
disconnect_bsp_APIC(!intr_remapping_enabled &&
ioapic_i8259.pin != -1);
}
Expand Down

0 comments on commit 532dd34

Please sign in to comment.