Skip to content

Commit

Permalink
bootmem: Fix __free_pages_bootmem() to use @order properly
Browse files Browse the repository at this point in the history
a226f6c (FRV: Clean up bootmem allocator's page freeing algorithm)
separated out __free_pages_bootmem() from free_all_bootmem_core().
__free_pages_bootmem() takes @order argument but it assumes @order is
either 0 or ilog2(BITS_PER_LONG).  Note that all the current users
match that assumption and this doesn't cause actual problems.

Fix it by using 1 << order instead of BITS_PER_LONG.

Signed-off-by: Tejun Heo <tj@kernel.org>
Link: http://lkml.kernel.org/r/1310457490-3356-3-git-send-email-tj@kernel.org
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
  • Loading branch information
Tejun Heo authored and H. Peter Anvin committed Jul 13, 2011
1 parent bf61549 commit 53348f2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions mm/page_alloc.c
Original file line number Diff line number Diff line change
Expand Up @@ -705,10 +705,10 @@ void __meminit __free_pages_bootmem(struct page *page, unsigned int order)
int loop;

prefetchw(page);
for (loop = 0; loop < BITS_PER_LONG; loop++) {
for (loop = 0; loop < (1 << order); loop++) {
struct page *p = &page[loop];

if (loop + 1 < BITS_PER_LONG)
if (loop + 1 < (1 << order))
prefetchw(p + 1);
__ClearPageReserved(p);
set_page_count(p, 0);
Expand Down

0 comments on commit 53348f2

Please sign in to comment.