Skip to content

Commit

Permalink
staging: brcm80211: remove struct osl_info from function prototypes
Browse files Browse the repository at this point in the history
A couple of functions with struct osl_info do not use this parameter
so it is removed from the function prototypes.

Reviewed-by: Brett Rudley <brudley@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Arend van Spriel authored and Greg Kroah-Hartman committed Mar 3, 2011
1 parent a30825a commit 537ebbb
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 18 deletions.
8 changes: 4 additions & 4 deletions drivers/staging/brcm80211/brcmfmac/dhd_linux.c
Original file line number Diff line number Diff line change
Expand Up @@ -1047,20 +1047,20 @@ int dhd_sendpkt(dhd_pub_t *dhdp, int ifidx, struct sk_buff *pktbuf)
}

static inline void *
osl_pkt_frmnative(struct osl_info *osh, struct sk_buff *skb)
osl_pkt_frmnative(struct sk_buff *skb)
{
return (void *)skb;
}
#define PKTFRMNATIVE(osh, skb) \
osl_pkt_frmnative((osh), (struct sk_buff *)(skb))
osl_pkt_frmnative((struct sk_buff *)(skb))

static inline struct sk_buff *
osl_pkt_tonative(struct osl_info *osh, void *pkt)
osl_pkt_tonative(void *pkt)
{
return (struct sk_buff *)pkt;
}
#define PKTTONATIVE(osh, pkt) \
osl_pkt_tonative((osh), (pkt))
osl_pkt_tonative((pkt))

static int dhd_start_xmit(struct sk_buff *skb, struct net_device *net)
{
Expand Down
3 changes: 1 addition & 2 deletions drivers/staging/brcm80211/brcmfmac/dhd_sdio.c
Original file line number Diff line number Diff line change
Expand Up @@ -2832,7 +2832,6 @@ dhd_bus_iovar_op(dhd_pub_t *dhdp, const char *name,

void dhd_bus_stop(struct dhd_bus *bus, bool enforce_mutex)
{
struct osl_info *osh = bus->dhd->osh;
u32 local_hostintmask;
u8 saveclk;
uint retries;
Expand Down Expand Up @@ -2882,7 +2881,7 @@ void dhd_bus_stop(struct dhd_bus *bus, bool enforce_mutex)
dhdsdio_clkctl(bus, CLK_SDONLY, false);

/* Clear the data packet queues */
pktq_flush(osh, &bus->txq, true);
pktq_flush(&bus->txq, true);

/* Clear any held glomming stuff */
if (bus->glomd)
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/brcm80211/brcmsmac/wlc_ampdu.c
Original file line number Diff line number Diff line change
Expand Up @@ -1195,7 +1195,7 @@ ampdu_cleanup_tid_ini(struct ampdu_info *ampdu, scb_ampdu_t *scb_ampdu, u8 tid,
ASSERT(ini == &scb_ampdu->ini[ini->tid]);

/* free all buffered tx packets */
pktq_pflush(ampdu->wlc->osh, &scb_ampdu->txq, ini->tid, true, NULL, 0);
pktq_pflush(&scb_ampdu->txq, ini->tid, true, NULL, 0);
}

/* initialize the initiator code for tid */
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/brcm80211/brcmsmac/wlc_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2725,7 +2725,7 @@ uint wlc_down(struct wlc_info *wlc)

/* flush tx queues */
for (qi = wlc->tx_queues; qi != NULL; qi = qi->next) {
pktq_flush(wlc->osh, &qi->q, true, NULL, 0);
pktq_flush(&qi->q, true, NULL, 0);
ASSERT(pktq_empty(&qi->q));
}

Expand Down
8 changes: 4 additions & 4 deletions drivers/staging/brcm80211/include/bcmutils.h
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,10 @@ extern void pkt_buf_free_skb(struct sk_buff *skb);

/* Empty the queue at particular precedence level */
#ifdef BRCM_FULLMAC
extern void pktq_pflush(struct osl_info *osh, struct pktq *pq, int prec,
extern void pktq_pflush(struct pktq *pq, int prec,
bool dir);
#else
extern void pktq_pflush(struct osl_info *osh, struct pktq *pq, int prec,
extern void pktq_pflush(struct pktq *pq, int prec,
bool dir, ifpkt_cb_t fn, int arg);
#endif /* BRCM_FULLMAC */

Expand Down Expand Up @@ -131,9 +131,9 @@ extern struct sk_buff *pktq_mdeq(struct pktq *pq, uint prec_bmp, int *prec_out);
/* prec_out may be NULL if caller is not interested in return value */
extern struct sk_buff *pktq_peek_tail(struct pktq *pq, int *prec_out);
#ifdef BRCM_FULLMAC
extern void pktq_flush(struct osl_info *osh, struct pktq *pq, bool dir);
extern void pktq_flush(struct pktq *pq, bool dir);
#else
extern void pktq_flush(struct osl_info *osh, struct pktq *pq, bool dir,
extern void pktq_flush(struct pktq *pq, bool dir,
ifpkt_cb_t fn, int arg);
#endif

Expand Down
12 changes: 6 additions & 6 deletions drivers/staging/brcm80211/util/bcmutils.c
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ struct sk_buff *BCMFASTPATH pktq_pdeq_tail(struct pktq *pq, int prec)
}

#ifdef BRCM_FULLMAC
void pktq_pflush(struct osl_info *osh, struct pktq *pq, int prec, bool dir)
void pktq_pflush(struct pktq *pq, int prec, bool dir)
{
struct pktq_prec *q;
struct sk_buff *p;
Expand All @@ -250,16 +250,16 @@ void pktq_pflush(struct osl_info *osh, struct pktq *pq, int prec, bool dir)
q->tail = NULL;
}

void pktq_flush(struct osl_info *osh, struct pktq *pq, bool dir)
void pktq_flush(struct pktq *pq, bool dir)
{
int prec;
for (prec = 0; prec < pq->num_prec; prec++)
pktq_pflush(osh, pq, prec, dir);
pktq_pflush(pq, prec, dir);
ASSERT(pq->len == 0);
}
#else /* !BRCM_FULLMAC */
void
pktq_pflush(struct osl_info *osh, struct pktq *pq, int prec, bool dir,
pktq_pflush(struct pktq *pq, int prec, bool dir,
ifpkt_cb_t fn, int arg)
{
struct pktq_prec *q;
Expand Down Expand Up @@ -291,12 +291,12 @@ pktq_pflush(struct osl_info *osh, struct pktq *pq, int prec, bool dir,
}
}

void pktq_flush(struct osl_info *osh, struct pktq *pq, bool dir,
void pktq_flush(struct pktq *pq, bool dir,
ifpkt_cb_t fn, int arg)
{
int prec;
for (prec = 0; prec < pq->num_prec; prec++)
pktq_pflush(osh, pq, prec, dir, fn, arg);
pktq_pflush(pq, prec, dir, fn, arg);
if (fn == NULL)
ASSERT(pq->len == 0);
}
Expand Down

0 comments on commit 537ebbb

Please sign in to comment.