Skip to content

Commit

Permalink
[S390] zcore: fix inline assembly in memcpy_real()
Browse files Browse the repository at this point in the history
memcpy_real uses the mvcle instruction. This instruction alters all used
registers (source, destination and 2 x count). Therefore we have to flag
those registers as input/output registers (+d). In addition to that, we
have to specify, that we read from memory designated by "src" and write to
memory designated by "dest".

Signed-off-by: Michael Holzheu <holzheu@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
  • Loading branch information
Michael Holzheu authored and Martin Schwidefsky committed Oct 12, 2007
1 parent cebe0fe commit 53a0868
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions drivers/s390/char/zcore.c
Original file line number Diff line number Diff line change
Expand Up @@ -141,15 +141,16 @@ static int memcpy_real(void *dest, unsigned long src, size_t count)

if (count == 0)
return 0;
flags = __raw_local_irq_stnsm(0xf8); /* switch to real mode */
flags = __raw_local_irq_stnsm(0xf8UL); /* switch to real mode */
asm volatile (
"0: mvcle %1,%2,0x0\n"
"1: jo 0b\n"
" lhi %0,0x0\n"
"2:\n"
EX_TABLE(1b,2b)
: "+d" (rc)
: "d" (_dest), "d" (_src), "d" (_len1), "d" (_len2)
: "+d" (rc), "+d" (_dest), "+d" (_src), "+d" (_len1),
"+d" (_len2), "=m" (*((long*)dest))
: "m" (*((long*)src))
: "cc", "memory");
__raw_local_irq_ssm(flags);

Expand Down

0 comments on commit 53a0868

Please sign in to comment.