ACPI: get_throttling_state() cannot be larger than state_count

Reported-by: Roel Kluin <roel.kluin@gmail.com> Acked-by: Zhao Yakui <yakui.zhao@intel.com> Signed-off-by: Len Brown <len.brown@intel.com>
git-mirror · Apr 3, 2009 · 53af9cf · 53af9cf
1 parent 2a9ef8e
commit 53af9cf
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/drivers/acpi/processor_throttling.c b/drivers/acpi/processor_throttling.c
@@ -783,11 +783,9 @@ static int acpi_get_throttling_state(struct acpi_processor *pr,
 		    (struct acpi_processor_tx_tss *)&(pr->throttling.
 						      states_tss[i]);
 		if (tx->control == value)
-			break;
+			return i;
 	}
-	if (i > pr->throttling.state_count)
-		i = -1;
-	return i;
+	return -1;
 }
 
 static int acpi_get_throttling_value(struct acpi_processor *pr,