Skip to content

Commit

Permalink
[S390] qdio: prevent oopsing if qdio_establish fails
Browse files Browse the repository at this point in the history
If qdio_establish fails we call qdio_shutdown to cleanup the
qdio subchannel. The tiq_list entry may not be valid at that
time, therefore we must ignore queues with an invalid list entry
in tiqdio_remove_input_queues.

Signed-off-by: Jan Glauber <jang@linux.vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
  • Loading branch information
Jan Glauber authored and Martin Schwidefsky committed Aug 21, 2008
1 parent 8853e50 commit 53b41ba
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion drivers/s390/cio/qdio_thinint.c
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,11 @@ void tiqdio_remove_input_queues(struct qdio_irq *irq_ptr)
struct qdio_q *q;
int i;

for_each_input_queue(irq_ptr, q, i) {
for (i = 0; i < irq_ptr->nr_input_qs; i++) {
q = irq_ptr->input_qs[i];
/* if establish triggered an error */
if (!q || !q->entry.prev || !q->entry.next)
continue;
list_del_rcu(&q->entry);
synchronize_rcu();
}
Expand Down

0 comments on commit 53b41ba

Please sign in to comment.