Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 289608
b: refs/heads/master
c: cd70469
h: refs/heads/master
v: v3
  • Loading branch information
Felipe Balbi authored and Greg Kroah-Hartman committed Mar 1, 2012
1 parent 87bef96 commit 544eda6
Show file tree
Hide file tree
Showing 8 changed files with 13 additions and 13 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 444aa7fa9bd752d19ce472d3e02558b987c3cc67
refs/heads/master: cd70469d084fde198dc07c1a31b8463562228a5a
6 changes: 3 additions & 3 deletions trunk/drivers/usb/core/hcd.c
Original file line number Diff line number Diff line change
Expand Up @@ -2352,7 +2352,7 @@ static int usb_hcd_request_irqs(struct usb_hcd *hcd,
"io mem" : "io base",
(unsigned long long)hcd->rsrc_start);
} else {
hcd->irq = -1;
hcd->irq = 0;
if (hcd->rsrc_start)
dev_info(hcd->self.controller, "%s 0x%08llx\n",
(hcd->driver->flags & HCD_MEMORY) ?
Expand Down Expand Up @@ -2508,7 +2508,7 @@ int usb_add_hcd(struct usb_hcd *hcd,
clear_bit(HCD_FLAG_POLL_RH, &hcd->flags);
del_timer_sync(&hcd->rh_timer);
err_hcd_driver_start:
if (usb_hcd_is_primary_hcd(hcd) && hcd->irq >= 0)
if (usb_hcd_is_primary_hcd(hcd) && hcd->irq > 0)
free_irq(irqnum, hcd);
err_request_irq:
err_hcd_driver_setup:
Expand Down Expand Up @@ -2573,7 +2573,7 @@ void usb_remove_hcd(struct usb_hcd *hcd)
del_timer_sync(&hcd->rh_timer);

if (usb_hcd_is_primary_hcd(hcd)) {
if (hcd->irq >= 0)
if (hcd->irq > 0)
free_irq(hcd->irq, hcd);
}

Expand Down
2 changes: 1 addition & 1 deletion trunk/drivers/usb/host/ohci-hcd.c
Original file line number Diff line number Diff line change
Expand Up @@ -899,7 +899,7 @@ static void ohci_stop (struct usb_hcd *hcd)
ohci_usb_reset (ohci);
ohci_writel (ohci, OHCI_INTR_MIE, &ohci->regs->intrdisable);
free_irq(hcd->irq, hcd);
hcd->irq = -1;
hcd->irq = 0;

if (quirk_zfmicro(ohci))
del_timer(&ohci->unlink_watchdog);
Expand Down
2 changes: 1 addition & 1 deletion trunk/drivers/usb/host/xhci-ring.c
Original file line number Diff line number Diff line change
Expand Up @@ -2396,7 +2396,7 @@ irqreturn_t xhci_irq(struct usb_hcd *hcd)
/* FIXME when MSI-X is supported and there are multiple vectors */
/* Clear the MSI-X event interrupt status */

if (hcd->irq != -1) {
if (hcd->irq) {
u32 irq_pending;
/* Acknowledge the PCI interrupt */
irq_pending = xhci_readl(xhci, &xhci->ir_set->irq_pending);
Expand Down
8 changes: 4 additions & 4 deletions trunk/drivers/usb/host/xhci.c
Original file line number Diff line number Diff line change
Expand Up @@ -224,13 +224,13 @@ static void xhci_free_irq(struct xhci_hcd *xhci)
int ret;

/* return if using legacy interrupt */
if (xhci_to_hcd(xhci)->irq >= 0)
if (xhci_to_hcd(xhci)->irq > 0)
return;

ret = xhci_free_msi(xhci);
if (!ret)
return;
if (pdev->irq >= 0)
if (pdev->irq > 0)
free_irq(pdev->irq, xhci_to_hcd(xhci));

return;
Expand Down Expand Up @@ -341,15 +341,15 @@ static int xhci_try_enable_msi(struct usb_hcd *hcd)
/* unregister the legacy interrupt */
if (hcd->irq)
free_irq(hcd->irq, hcd);
hcd->irq = -1;
hcd->irq = 0;

ret = xhci_setup_msix(xhci);
if (ret)
/* fall back to msi*/
ret = xhci_setup_msi(xhci);

if (!ret)
/* hcd->irq is -1, we have MSI */
/* hcd->irq is 0, we have MSI */
return 0;

if (!pdev->irq) {
Expand Down
2 changes: 1 addition & 1 deletion trunk/drivers/usb/musb/musb_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1987,7 +1987,7 @@ musb_init_controller(struct device *dev, int nIrq, void __iomem *ctrl)
musb->xceiv->otg->default_a = 1;
musb->xceiv->state = OTG_STATE_A_IDLE;

status = usb_add_hcd(musb_to_hcd(musb), -1, 0);
status = usb_add_hcd(musb_to_hcd(musb), 0, 0);

hcd->self.uses_pio_for_control = 1;
dev_dbg(musb->controller, "%s mode, status %d, devctl %02x %c\n",
Expand Down
2 changes: 1 addition & 1 deletion trunk/drivers/usb/musb/musb_gadget.c
Original file line number Diff line number Diff line change
Expand Up @@ -1957,7 +1957,7 @@ static int musb_gadget_start(struct usb_gadget *g,
* handles power budgeting ... this way also
* ensures HdrcStart is indirectly called.
*/
retval = usb_add_hcd(musb_to_hcd(musb), -1, 0);
retval = usb_add_hcd(musb_to_hcd(musb), 0, 0);
if (retval < 0) {
dev_dbg(musb->controller, "add_hcd failed, %d\n", retval);
goto err2;
Expand Down
2 changes: 1 addition & 1 deletion trunk/include/linux/usb/hcd.h
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ struct usb_hcd {
unsigned authorized_default:1;
unsigned has_tt:1; /* Integrated TT in root hub */

int irq; /* irq allocated */
unsigned int irq; /* irq allocated */
void __iomem *regs; /* device memory/io */
u64 rsrc_start; /* memory/io resource start */
u64 rsrc_len; /* memory/io resource length */
Expand Down

0 comments on commit 544eda6

Please sign in to comment.