Skip to content

Commit

Permalink
[media] lgdt330x: warn on errors blasting modulation config to the lg…
Browse files Browse the repository at this point in the history
…dt3303

fix the following build warning:

lgdt330x.c: In function "lgdt330x_set_parameters":
lgdt330x.c:346:6: warning: variable "err" set but not used
[-Wunused-but-set-variable]

Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Michael Krufky authored and Mauro Carvalho Chehab committed Dec 30, 2011
1 parent 26110da commit 54828d1
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion drivers/media/dvb/frontends/lgdt330x.c
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ static int lgdt330x_set_parameters(struct dvb_frontend* fe,

static u8 top_ctrl_cfg[] = { TOP_CONTROL, 0x03 };

int err;
int err = 0;
/* Change only if we are actually changing the modulation */
if (state->current_modulation != param->u.vsb.modulation) {
switch(param->u.vsb.modulation) {
Expand Down Expand Up @@ -402,6 +402,11 @@ static int lgdt330x_set_parameters(struct dvb_frontend* fe,
printk(KERN_WARNING "lgdt330x: %s: Modulation type(%d) UNSUPPORTED\n", __func__, param->u.vsb.modulation);
return -1;
}
if (err < 0)
printk(KERN_WARNING "lgdt330x: %s: error blasting "
"bytes to lgdt3303 for modulation type(%d)\n",
__func__, param->u.vsb.modulation);

/*
* select serial or parallel MPEG harware interface
* Serial: 0x04 for LGDT3302 or 0x40 for LGDT3303
Expand Down

0 comments on commit 54828d1

Please sign in to comment.