Skip to content

Commit

Permalink
ALSA: hda/ca0132 - Fix possible NULL dereference
Browse files Browse the repository at this point in the history
Spotted by smatch,
  sound/pci/hda/patch_ca0132.c:1950 dspxfr_image() error: potential
  null dereference 'dma_engine'.  (kzalloc returns null)
  sound/pci/hda/patch_ca0132.c:1950 dspxfr_image() error: we
  previously assumed 'dma_engine' could be null (see line 1857)

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Takashi Iwai committed Jan 15, 2013
1 parent 425a788 commit 549e829
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions sound/pci/hda/patch_ca0132.c
Original file line number Diff line number Diff line change
Expand Up @@ -2416,15 +2416,13 @@ static int dspxfr_image(struct hda_codec *codec,
return -EINVAL;

dma_engine = kzalloc(sizeof(*dma_engine), GFP_KERNEL);
if (!dma_engine) {
status = -ENOMEM;
goto exit;
}
if (!dma_engine)
return -ENOMEM;

dma_engine->dmab = kzalloc(sizeof(*dma_engine->dmab), GFP_KERNEL);
if (!dma_engine->dmab) {
status = -ENOMEM;
goto exit;
kfree(dma_engine);
return -ENOMEM;
}

dma_engine->codec = codec;
Expand Down

0 comments on commit 549e829

Please sign in to comment.