Skip to content

Commit

Permalink
sctp: use list_move_tail instead of list_del/list_add_tail
Browse files Browse the repository at this point in the history
Using list_move_tail() instead of list_del() + list_add_tail().

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Wei Yongjun authored and David S. Miller committed Sep 4, 2012
1 parent 6e129d0 commit 54a2792
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions net/sctp/outqueue.c
Original file line number Diff line number Diff line change
Expand Up @@ -591,9 +591,8 @@ static int sctp_outq_flush_rtx(struct sctp_outq *q, struct sctp_packet *pkt,
* next chunk.
*/
if (chunk->tsn_gap_acked) {
list_del(&chunk->transmitted_list);
list_add_tail(&chunk->transmitted_list,
&transport->transmitted);
list_move_tail(&chunk->transmitted_list,
&transport->transmitted);
continue;
}

Expand Down Expand Up @@ -657,9 +656,8 @@ static int sctp_outq_flush_rtx(struct sctp_outq *q, struct sctp_packet *pkt,
/* The append was successful, so add this chunk to
* the transmitted list.
*/
list_del(&chunk->transmitted_list);
list_add_tail(&chunk->transmitted_list,
&transport->transmitted);
list_move_tail(&chunk->transmitted_list,
&transport->transmitted);

/* Mark the chunk as ineligible for fast retransmit
* after it is retransmitted.
Expand Down

0 comments on commit 54a2792

Please sign in to comment.