Skip to content

Commit

Permalink
Bluetooth: Add l2cap_chan->ops->ready()
Browse files Browse the repository at this point in the history
This move socket specific code to l2cap_sock.c.

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
  • Loading branch information
Andrei Emeltchenko authored and Johan Hedberg committed Jun 5, 2012
1 parent c0df7f6 commit 54a59aa
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 15 deletions.
1 change: 1 addition & 0 deletions include/net/bluetooth/l2cap.h
Original file line number Diff line number Diff line change
Expand Up @@ -534,6 +534,7 @@ struct l2cap_ops {
void (*close) (struct l2cap_chan *chan);
void (*state_change) (struct l2cap_chan *chan,
int state);
void (*ready) (struct l2cap_chan *chan);
struct sk_buff *(*alloc_skb) (struct l2cap_chan *chan,
unsigned long len, int nb);
};
Expand Down
18 changes: 3 additions & 15 deletions net/bluetooth/l2cap_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -931,26 +931,14 @@ static void l2cap_send_conn_req(struct l2cap_chan *chan)

static void l2cap_chan_ready(struct l2cap_chan *chan)
{
struct sock *sk = chan->sk;
struct sock *parent;

lock_sock(sk);

parent = bt_sk(sk)->parent;

BT_DBG("sk %p, parent %p", sk, parent);

/* This clears all conf flags, including CONF_NOT_COMPLETE */
chan->conf_state = 0;
__clear_chan_timer(chan);

__l2cap_state_change(chan, BT_CONNECTED);
sk->sk_state_change(sk);
chan->state = BT_CONNECTED;

if (parent)
parent->sk_data_ready(parent, 0);

release_sock(sk);
if (chan->ops->ready)
chan->ops->ready(chan);
}

static void l2cap_do_start(struct l2cap_chan *chan)
Expand Down
21 changes: 21 additions & 0 deletions net/bluetooth/l2cap_sock.c
Original file line number Diff line number Diff line change
Expand Up @@ -1014,13 +1014,34 @@ static struct sk_buff *l2cap_sock_alloc_skb_cb(struct l2cap_chan *chan,
return skb;
}

static void l2cap_sock_ready_cb(struct l2cap_chan *chan)
{
struct sock *sk = chan->data;
struct sock *parent;

lock_sock(sk);

parent = bt_sk(sk)->parent;

BT_DBG("sk %p, parent %p", sk, parent);

sk->sk_state = BT_CONNECTED;
sk->sk_state_change(sk);

if (parent)
parent->sk_data_ready(parent, 0);

release_sock(sk);
}

static struct l2cap_ops l2cap_chan_ops = {
.name = "L2CAP Socket Interface",
.new_connection = l2cap_sock_new_connection_cb,
.recv = l2cap_sock_recv_cb,
.close = l2cap_sock_close_cb,
.teardown = l2cap_sock_teardown_cb,
.state_change = l2cap_sock_state_change_cb,
.ready = l2cap_sock_ready_cb,
.alloc_skb = l2cap_sock_alloc_skb_cb,
};

Expand Down

0 comments on commit 54a59aa

Please sign in to comment.