Skip to content

Commit

Permalink
block: fix bug in ptbl lookup cache
Browse files Browse the repository at this point in the history
Neil writes:

   Hi Jens,

    I've found a little bug for you.  It was introduced by
        a6f2365

        block: add one-hit cache for disk partition lookup

    and has the effect of killing my machine whenever I try to assemble
    an md array :-(
    One of the devices in the array has partitions, and mdadm always
    deletes partitions before putting a whole-device in an array (as it
    can cause confusion).  The next IO to that device locks the machine.
    I don't really understand exactly why it locks up, but it happens in
    disk_map_sector_rcu().  This patch fixes it.

Which is due to a missing clear of the (now) stale partition lookup
data. So clear that when we delete a partition.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
  • Loading branch information
Neil Brown authored and Jens Axboe committed Jan 9, 2009
1 parent 2150edc commit 54b0d12
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions fs/partitions/check.c
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,7 @@ void delete_partition(struct gendisk *disk, int partno)

blk_free_devt(part_devt(part));
rcu_assign_pointer(ptbl->part[partno], NULL);
rcu_assign_pointer(ptbl->last_lookup, NULL);
kobject_put(part->holder_dir);
device_del(part_to_dev(part));

Expand Down

0 comments on commit 54b0d12

Please sign in to comment.