Skip to content

Commit

Permalink
UBIFS: Delete unnecessary checks before the function call "iput"
Browse files Browse the repository at this point in the history
The iput() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Richard Weinberger <richard@nod.at>
  • Loading branch information
Markus Elfring authored and Richard Weinberger committed Nov 6, 2015
1 parent a396ce4 commit 54bcfdf
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions fs/ubifs/recovery.c
Original file line number Diff line number Diff line change
Expand Up @@ -1331,8 +1331,7 @@ void ubifs_destroy_size_tree(struct ubifs_info *c)
struct size_entry *e, *n;

rbtree_postorder_for_each_entry_safe(e, n, &c->size_tree, rb) {
if (e->inode)
iput(e->inode);
iput(e->inode);
kfree(e);
}

Expand Down Expand Up @@ -1533,8 +1532,7 @@ int ubifs_recover_size(struct ubifs_info *c)
err = fix_size_in_place(c, e);
if (err)
return err;
if (e->inode)
iput(e->inode);
iput(e->inode);
}
}

Expand Down

0 comments on commit 54bcfdf

Please sign in to comment.