Skip to content

Commit

Permalink
qeth: Drop ARP packages on HiperSockets interface with NOARP attribute.
Browse files Browse the repository at this point in the history
A network interface can get ARP packets even when the interface has
NOARP specified. In a HiperSockets environment this disturbs receiving
systems when packets are sent on the multicast queue. (E.g. TCP/IP on
z/VM issues messages reporting invalid data on the HiperSockets
interface.)
Qeth will no longer send ARP packets on HiperSockets interface when
interface has the NOARP attribute.

Signed-off-by: Klaus D. Wacker <kdwacker@de.ibm.com>
Signed-off-by: Ursula Braun <braunu@de.ibm.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Klaus D. Wacker authored and Jeff Garzik committed Aug 31, 2007
1 parent 6e55cab commit 54d0f56
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions drivers/s390/net/qeth_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2505,7 +2505,7 @@ qeth_rebuild_skb_fake_ll_tr(struct qeth_card *card, struct sk_buff *skb,
struct iphdr *ip_hdr;

QETH_DBF_TEXT(trace,5,"skbfktr");
skb_set_mac_header(skb, -QETH_FAKE_LL_LEN_TR);
skb_set_mac_header(skb, (int)-QETH_FAKE_LL_LEN_TR);
/* this is a fake ethernet header */
fake_hdr = tr_hdr(skb);

Expand Down Expand Up @@ -4710,9 +4710,15 @@ qeth_send_packet(struct qeth_card *card, struct sk_buff *skb)
if (card->info.type != QETH_CARD_TYPE_IQD)
rc = qeth_do_send_packet(card, queue, new_skb, hdr,
elements_needed, ctx);
else
else {
if ((skb->protocol == htons(ETH_P_ARP)) &&
(card->dev->flags & IFF_NOARP)) {
__qeth_free_new_skb(skb, new_skb);
return -EPERM;
}
rc = qeth_do_send_packet_fast(card, queue, new_skb, hdr,
elements_needed, ctx);
}
if (!rc) {
card->stats.tx_packets++;
card->stats.tx_bytes += tx_bytes;
Expand Down

0 comments on commit 54d0f56

Please sign in to comment.