Skip to content

Commit

Permalink
x86, olpc: Constify an olpc_ofw() arg
Browse files Browse the repository at this point in the history
The arguments passed to OFW shouldn't be modified; update the 'args'
argument of olpc_ofw to reflect this.  This saves us some later
casting away of consts.

Signed-off-by: Andres Salomon <dilinger@queued.net>
LKML-Reference: <20100628220029.1555ac24@debian>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
  • Loading branch information
Andres Salomon authored and H. Peter Anvin committed Jul 31, 2010
1 parent 2597186 commit 54e5bc0
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion arch/x86/include/asm/olpc_ofw.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
#define olpc_ofw(name, args, res) \
__olpc_ofw((name), ARRAY_SIZE(args), args, ARRAY_SIZE(res), res)

extern int __olpc_ofw(const char *name, int nr_args, void **args, int nr_res,
extern int __olpc_ofw(const char *name, int nr_args, const void **args, int nr_res,
void **res);

/* determine whether OFW is available and lives in the proper memory */
Expand Down
2 changes: 1 addition & 1 deletion arch/x86/kernel/olpc.c
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ static void __init platform_detect(void)
{
size_t propsize;
__be32 rev;
void *args[] = { NULL, "board-revision-int", &rev, (void *)4 };
const void *args[] = { NULL, "board-revision-int", &rev, (void *)4 };
void *res[] = { &propsize };

if (olpc_ofw("getprop", args, res) || propsize != 4) {
Expand Down
2 changes: 1 addition & 1 deletion arch/x86/kernel/olpc_ofw.c
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ void __init setup_olpc_ofw_pgd(void)
early_iounmap(base, sizeof(olpc_ofw_pgd) * PTRS_PER_PGD);
}

int __olpc_ofw(const char *name, int nr_args, void **args, int nr_res,
int __olpc_ofw(const char *name, int nr_args, const void **args, int nr_res,
void **res)
{
int ofw_args[MAXARGS + 3];
Expand Down

0 comments on commit 54e5bc0

Please sign in to comment.