Skip to content

Commit

Permalink
IB/mlx4: Get rid of max_inline_data calculation
Browse files Browse the repository at this point in the history
The calculation of max_inline_data in set_kernel_sq_size() is bogus,
since it doesn't take into account the fact that inline segments may
not cross a 64-byte boundary, and hence multiple inline segments will
probably need to be used to post large inline sends.

We don't support inline sends for kernel QPs anyway, so there's no
point in doing this calculation anyway, since the field is just zeroed
out a little later.  So just delete the bogus calculation.

Signed-off-by: Roland Dreier <rolandd@cisco.com>
  • Loading branch information
Roland Dreier committed Jun 18, 2007
1 parent 0e6e741 commit 54e95f8
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions drivers/infiniband/hw/mlx4/qp.c
Original file line number Diff line number Diff line change
Expand Up @@ -277,8 +277,8 @@ static int set_kernel_sq_size(struct mlx4_ib_dev *dev, struct ib_qp_cap *cap,

cap->max_send_wr = qp->sq.max_post = qp->sq.wqe_cnt - qp->sq_spare_wqes;
cap->max_send_sge = qp->sq.max_gs;
cap->max_inline_data = (1 << qp->sq.wqe_shift) - send_wqe_overhead(type) -
sizeof (struct mlx4_wqe_inline_seg);
/* We don't support inline sends for kernel QPs (yet) */
cap->max_inline_data = 0;

return 0;
}
Expand Down Expand Up @@ -390,9 +390,6 @@ static int create_qp_common(struct mlx4_ib_dev *dev, struct ib_pd *pd,
err = -ENOMEM;
goto err_wrid;
}

/* We don't support inline sends for kernel QPs (yet) */
init_attr->cap.max_inline_data = 0;
}

err = mlx4_qp_alloc(dev->dev, sqpn, &qp->mqp);
Expand Down

0 comments on commit 54e95f8

Please sign in to comment.