Skip to content

Commit

Permalink
[SPARC]: Fix TIF_USEDFPU flag atomicity
Browse files Browse the repository at this point in the history
From: William Lee Irwin III <wli@holomorphy.com>

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
William Lee Irwin III authored and David S. Miller committed Mar 13, 2007
1 parent c0a79b2 commit 54f565e
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
16 changes: 8 additions & 8 deletions arch/sparc/kernel/process.c
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ void exit_thread(void)
#ifndef CONFIG_SMP
if(last_task_used_math == current) {
#else
if(current_thread_info()->flags & _TIF_USEDFPU) {
if (test_thread_flag(TIF_USEDFPU)) {
#endif
/* Keep process from leaving FPU in a bogon state. */
put_psr(get_psr() | PSR_EF);
Expand All @@ -357,7 +357,7 @@ void exit_thread(void)
#ifndef CONFIG_SMP
last_task_used_math = NULL;
#else
current_thread_info()->flags &= ~_TIF_USEDFPU;
clear_thread_flag(TIF_USEDFPU);
#endif
}
}
Expand All @@ -371,7 +371,7 @@ void flush_thread(void)
#ifndef CONFIG_SMP
if(last_task_used_math == current) {
#else
if(current_thread_info()->flags & _TIF_USEDFPU) {
if (test_thread_flag(TIF_USEDFPU)) {
#endif
/* Clean the fpu. */
put_psr(get_psr() | PSR_EF);
Expand All @@ -380,7 +380,7 @@ void flush_thread(void)
#ifndef CONFIG_SMP
last_task_used_math = NULL;
#else
current_thread_info()->flags &= ~_TIF_USEDFPU;
clear_thread_flag(TIF_USEDFPU);
#endif
}

Expand Down Expand Up @@ -466,13 +466,13 @@ int copy_thread(int nr, unsigned long clone_flags, unsigned long sp,
#ifndef CONFIG_SMP
if(last_task_used_math == current) {
#else
if(current_thread_info()->flags & _TIF_USEDFPU) {
if (test_thread_flag(TIF_USEDFPU)) {
#endif
put_psr(get_psr() | PSR_EF);
fpsave(&p->thread.float_regs[0], &p->thread.fsr,
&p->thread.fpqueue[0], &p->thread.fpqdepth);
#ifdef CONFIG_SMP
current_thread_info()->flags &= ~_TIF_USEDFPU;
clear_thread_flag(TIF_USEDFPU);
#endif
}

Expand Down Expand Up @@ -609,13 +609,13 @@ int dump_fpu (struct pt_regs * regs, elf_fpregset_t * fpregs)
return 1;
}
#ifdef CONFIG_SMP
if (current_thread_info()->flags & _TIF_USEDFPU) {
if (test_thread_flag(TIF_USEDFPU)) {
put_psr(get_psr() | PSR_EF);
fpsave(&current->thread.float_regs[0], &current->thread.fsr,
&current->thread.fpqueue[0], &current->thread.fpqdepth);
if (regs != NULL) {
regs->psr &= ~(PSR_EF);
current_thread_info()->flags &= ~(_TIF_USEDFPU);
clear_thread_flag(TIF_USEDFPU);
}
}
#else
Expand Down
6 changes: 3 additions & 3 deletions arch/sparc/kernel/traps.c
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ void do_fpd_trap(struct pt_regs *regs, unsigned long pc, unsigned long npc,
} else {
fpload(&current->thread.float_regs[0], &current->thread.fsr);
}
current_thread_info()->flags |= _TIF_USEDFPU;
set_thread_flag(TIF_USEDFPU);
#endif
}

Expand Down Expand Up @@ -290,7 +290,7 @@ void do_fpe_trap(struct pt_regs *regs, unsigned long pc, unsigned long npc,
#ifndef CONFIG_SMP
if(!fpt) {
#else
if(!(task_thread_info(fpt)->flags & _TIF_USEDFPU)) {
if (!test_tsk_thread_flag(fpt, TIF_USEDFPU)) {
#endif
fpsave(&fake_regs[0], &fake_fsr, &fake_queue[0], &fake_depth);
regs->psr &= ~PSR_EF;
Expand Down Expand Up @@ -333,7 +333,7 @@ void do_fpe_trap(struct pt_regs *regs, unsigned long pc, unsigned long npc,
/* nope, better SIGFPE the offending process... */

#ifdef CONFIG_SMP
task_thread_info(fpt)->flags &= ~_TIF_USEDFPU;
clear_tsk_thread_flag(fpt, TIF_USEDFPU);
#endif
if(psr & PSR_PS) {
/* The first fsr store/load we tried trapped,
Expand Down

0 comments on commit 54f565e

Please sign in to comment.