Skip to content

Commit

Permalink
[PATCH] lockdep: improve debug output
Browse files Browse the repository at this point in the history
Make lockdep print which lock is held, in the "kfree() of a live lock"
scenario.

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Arjan van de Ven authored and Linus Torvalds committed Jul 10, 2006
1 parent 5fca80e commit 55794a4
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions kernel/lockdep.c
Original file line number Diff line number Diff line change
Expand Up @@ -2551,7 +2551,7 @@ static inline int in_range(const void *start, const void *addr, const void *end)

static void
print_freed_lock_bug(struct task_struct *curr, const void *mem_from,
const void *mem_to)
const void *mem_to, struct held_lock *hlock)
{
if (!debug_locks_off())
return;
Expand All @@ -2563,6 +2563,7 @@ print_freed_lock_bug(struct task_struct *curr, const void *mem_from,
printk( "-------------------------\n");
printk("%s/%d is freeing memory %p-%p, with a lock still held there!\n",
curr->comm, curr->pid, mem_from, mem_to-1);
print_lock(hlock);
lockdep_print_held_locks(curr);

printk("\nstack backtrace:\n");
Expand Down Expand Up @@ -2596,7 +2597,7 @@ void debug_check_no_locks_freed(const void *mem_from, unsigned long mem_len)
!in_range(mem_from, lock_to, mem_to))
continue;

print_freed_lock_bug(curr, mem_from, mem_to);
print_freed_lock_bug(curr, mem_from, mem_to, hlock);
break;
}
local_irq_restore(flags);
Expand Down

0 comments on commit 55794a4

Please sign in to comment.