Skip to content

Commit

Permalink
drm/i915: Cleanup gen3 irq uninstall
Browse files Browse the repository at this point in the history
Bring the for-each-pipe loops together so that the code is easier on the
eyes.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
  • Loading branch information
Chris Wilson authored and Daniel Vetter committed May 3, 2012
1 parent 00d98eb commit 55b3975
Showing 1 changed file with 4 additions and 7 deletions.
11 changes: 4 additions & 7 deletions drivers/gpu/drm/i915/i915_irq.c
Original file line number Diff line number Diff line change
Expand Up @@ -2527,9 +2527,6 @@ static void i915_irq_uninstall(struct drm_device * dev)
drm_i915_private_t *dev_priv = (drm_i915_private_t *) dev->dev_private;
int pipe;

if (!dev_priv)
return;

dev_priv->vblank_pipe = 0;

if (I915_HAS_HOTPLUG(dev)) {
Expand All @@ -2538,14 +2535,14 @@ static void i915_irq_uninstall(struct drm_device * dev)
}

I915_WRITE16(HWSTAM, 0xffff);
for_each_pipe(pipe)
for_each_pipe(pipe) {
/* Clear enable bits; then clear status bits */
I915_WRITE(PIPESTAT(pipe), 0);
I915_WRITE(PIPESTAT(pipe), I915_READ(PIPESTAT(pipe)));
}
I915_WRITE(IMR, 0xffffffff);
I915_WRITE(IER, 0x0);

for_each_pipe(pipe)
I915_WRITE(PIPESTAT(pipe),
I915_READ(PIPESTAT(pipe)) & 0x8000ffff);
I915_WRITE(IIR, I915_READ(IIR));
}

Expand Down

0 comments on commit 55b3975

Please sign in to comment.