Skip to content

Commit

Permalink
[PATCH] chardev: GPIO for SCx200 & PC-8736x: device minor numbers are…
Browse files Browse the repository at this point in the history
… unsigned ints

Per kernel headers, device minor numbers are unsigned ints.  Do the same in
this driver.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Jim Cromie authored and Linus Torvalds committed Jun 28, 2006
1 parent 979b5ec commit 55b8c04
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion arch/i386/kernel/scx200.c
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ static int __devinit scx200_probe(struct pci_dev *pdev, const struct pci_device_
return 0;
}

u32 scx200_gpio_configure(int index, u32 mask, u32 bits)
u32 scx200_gpio_configure(unsigned index, u32 mask, u32 bits)
{
u32 config, new_config;
unsigned long flags;
Expand Down
14 changes: 7 additions & 7 deletions include/linux/scx200_gpio.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include <linux/spinlock.h>

u32 scx200_gpio_configure(int index, u32 set, u32 clear);
u32 scx200_gpio_configure(unsigned index, u32 set, u32 clear);

extern unsigned scx200_gpio_base;
extern long scx200_gpio_shadow[2];
Expand All @@ -17,7 +17,7 @@ extern long scx200_gpio_shadow[2];

/* returns the value of the GPIO pin */

static inline int scx200_gpio_get(int index) {
static inline int scx200_gpio_get(unsigned index) {
__SCx200_GPIO_BANK;
__SCx200_GPIO_IOADDR + 0x04;
__SCx200_GPIO_INDEX;
Expand All @@ -29,7 +29,7 @@ static inline int scx200_gpio_get(int index) {
driven if the GPIO is configured as an output, it might not be the
state of the GPIO right now if the GPIO is configured as an input) */

static inline int scx200_gpio_current(int index) {
static inline int scx200_gpio_current(unsigned index) {
__SCx200_GPIO_BANK;
__SCx200_GPIO_INDEX;

Expand All @@ -38,7 +38,7 @@ static inline int scx200_gpio_current(int index) {

/* drive the GPIO signal high */

static inline void scx200_gpio_set_high(int index) {
static inline void scx200_gpio_set_high(unsigned index) {
__SCx200_GPIO_BANK;
__SCx200_GPIO_IOADDR;
__SCx200_GPIO_SHADOW;
Expand All @@ -49,7 +49,7 @@ static inline void scx200_gpio_set_high(int index) {

/* drive the GPIO signal low */

static inline void scx200_gpio_set_low(int index) {
static inline void scx200_gpio_set_low(unsigned index) {
__SCx200_GPIO_BANK;
__SCx200_GPIO_IOADDR;
__SCx200_GPIO_SHADOW;
Expand All @@ -60,7 +60,7 @@ static inline void scx200_gpio_set_low(int index) {

/* drive the GPIO signal to state */

static inline void scx200_gpio_set(int index, int state) {
static inline void scx200_gpio_set(unsigned index, int state) {
__SCx200_GPIO_BANK;
__SCx200_GPIO_IOADDR;
__SCx200_GPIO_SHADOW;
Expand All @@ -73,7 +73,7 @@ static inline void scx200_gpio_set(int index, int state) {
}

/* toggle the GPIO signal */
static inline void scx200_gpio_change(int index) {
static inline void scx200_gpio_change(unsigned index) {
__SCx200_GPIO_BANK;
__SCx200_GPIO_IOADDR;
__SCx200_GPIO_SHADOW;
Expand Down

0 comments on commit 55b8c04

Please sign in to comment.