Skip to content

Commit

Permalink
fix return value of __pppoe_xmit() method.
Browse files Browse the repository at this point in the history
Hi,
 __pppoe_xmit() in drivers/net/pppoe always returns 1.
When the methods fails (via goto abort), it should return 0 and not 1.

Regards,
Rami Rosen

Signed-off-by: Rami Rosen <ramirose@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Rami Rosen authored and David S. Miller committed Jun 5, 2010
1 parent 5918e2f commit 55c95e7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/pppoe.c
Original file line number Diff line number Diff line change
Expand Up @@ -949,7 +949,7 @@ static int __pppoe_xmit(struct sock *sk, struct sk_buff *skb)

abort:
kfree_skb(skb);
return 1;
return 0;
}

/************************************************************************
Expand Down

0 comments on commit 55c95e7

Please sign in to comment.