Skip to content

Commit

Permalink
libata: kill the infamous abnormal status message
Browse files Browse the repository at this point in the history
The infamous abnormal status message triggers on not so abnormal cases
including empty port and even when it's being triggered on actual
errors the info it provides is redundant and out of context - higher
level functions will print the info in better safe later anyway.

Also, by being triggered all the time, it leads people to think that
the abnormality is somehow related to all ATA and system problems
they're experiencing and gives owners of healthy systems unfounded
doubts about the integrity of the universe.  Make it a DPRINTK and
save the universe.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Tejun Heo authored and Jeff Garzik committed Jun 27, 2007
1 parent 62877f6 commit 55f3952
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions include/linux/libata.h
Original file line number Diff line number Diff line change
Expand Up @@ -1088,11 +1088,9 @@ static inline u8 ata_wait_idle(struct ata_port *ap)
{
u8 status = ata_busy_wait(ap, ATA_BUSY | ATA_DRQ, 1000);

if (status != 0xff && (status & (ATA_BUSY | ATA_DRQ))) {
if (ata_msg_warn(ap))
printk(KERN_WARNING "ATA: abnormal status 0x%X on port 0x%p\n",
status, ap->ioaddr.status_addr);
}
if (status != 0xff && (status & (ATA_BUSY | ATA_DRQ)))
DPRINTK("ATA: abnormal status 0x%X on port 0x%p\n",
status, ap->ioaddr.status_addr);

return status;
}
Expand Down

0 comments on commit 55f3952

Please sign in to comment.