Skip to content

Commit

Permalink
bridge: notifier called with the wrong device
Browse files Browse the repository at this point in the history
If a new device is added to a bridge, the ethernet address of the
bridge network device may change. When the address changes, the
appropriate callback is called, but with the wrong device argument.
The address of the bridge device (ie br0) changes not the address
of the device being passed to add_if (ie eth0).

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
stephen hemminger authored and David S. Miller committed Jul 23, 2011
1 parent 0652cac commit 56139fc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/bridge/br_if.c
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ int br_add_if(struct net_bridge *br, struct net_device *dev)
br_ifinfo_notify(RTM_NEWLINK, p);

if (changed_addr)
call_netdevice_notifiers(NETDEV_CHANGEADDR, dev);
call_netdevice_notifiers(NETDEV_CHANGEADDR, br->dev);

dev_set_mtu(br->dev, br_min_mtu(br));

Expand Down

0 comments on commit 56139fc

Please sign in to comment.