Skip to content

Commit

Permalink
sm501fb: direct color visual does not work
Browse files Browse the repository at this point in the history
The sm501fb palette code clearly does not handle direct color so change the
driver to use true color visual for 16bpp.

Signed-off-by: Ville Syrjala <syrjala@sci.fi>
Acked-by: Magnus Damm <damm@igel.co.jp>
Acked-by: Ben Dooks <ben-linux@fluff.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Ville Syrjala authored and Linus Torvalds committed Mar 5, 2008
1 parent 5cba6d2 commit 5619d82
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/video/sm501fb.c
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ static int sm501fb_set_par_common(struct fb_info *info,
break;

case 16:
info->fix.visual = FB_VISUAL_DIRECTCOLOR;
info->fix.visual = FB_VISUAL_TRUECOLOR;
break;

case 32:
Expand Down Expand Up @@ -613,6 +613,7 @@ static int sm501fb_set_par_crt(struct fb_info *info)

case 16:
control |= SM501_DC_CRT_CONTROL_16BPP;
sm501fb_setup_gamma(fbi, SM501_DC_CRT_PALETTE);
break;

case 32:
Expand Down Expand Up @@ -750,6 +751,7 @@ static int sm501fb_set_par_pnl(struct fb_info *info)

case 16:
control |= SM501_DC_PANEL_CONTROL_16BPP;
sm501fb_setup_gamma(fbi, SM501_DC_PANEL_PALETTE);
break;

case 32:
Expand Down

0 comments on commit 5619d82

Please sign in to comment.