Skip to content

Commit

Permalink
[PATCH] fix PROMISC/bridging in TLAN driver
Browse files Browse the repository at this point in the history
This has been a problem for me for ages.  When using bridging, the driver
is switched into promiscuous mode before the link init is complete.  The
init complete routine then resets the promisc bit on the card so the kernel
still thinks the card is in promiscuous mode but the card isn't.  doh.

I think this bug only shows up in bridging when the bridge is started at
boot time (or something else that sets promisc at the same time the card
was started).  If promisc is enabled later it works.

Here's a trivial (and hopefully correct) patch that works for me. It
just calls the promisc/multicast setup routine after init.

Cc: Jeff Garzik <jgarzik@pobox.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
  • Loading branch information
James Harper authored and Jeff Garzik committed May 16, 2005
1 parent 15efa9b commit 562faf4
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/net/tlan.c
Original file line number Diff line number Diff line change
Expand Up @@ -2392,6 +2392,7 @@ TLan_FinishReset( struct net_device *dev )
TLan_SetTimer( dev, (10*HZ), TLAN_TIMER_FINISH_RESET );
return;
}
TLan_SetMulticastList(dev);

} /* TLan_FinishReset */

Expand Down

0 comments on commit 562faf4

Please sign in to comment.