Skip to content

Commit

Permalink
sis190: read the mac address from the eeprom first
Browse files Browse the repository at this point in the history
Reading a serie of zero from the cmos sram area do not work
well with is_valid_ether_addr(). Let's read the mac address
from the eeprom first as it seems more reliable.

Fix for http://bugzilla.kernel.org/show_bug.cgi?id=9831

Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Francois Romieu authored and Jeff Garzik committed Feb 24, 2008
1 parent 98e0f52 commit 563e0ae
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions drivers/net/sis190.c
Original file line number Diff line number Diff line change
Expand Up @@ -1633,13 +1633,18 @@ static inline void sis190_init_rxfilter(struct net_device *dev)
static int __devinit sis190_get_mac_addr(struct pci_dev *pdev,
struct net_device *dev)
{
u8 from;
int rc;

rc = sis190_get_mac_addr_from_eeprom(pdev, dev);
if (rc < 0) {
u8 reg;

pci_read_config_byte(pdev, 0x73, &from);
pci_read_config_byte(pdev, 0x73, &reg);

return (from & 0x00000001) ?
sis190_get_mac_addr_from_apc(pdev, dev) :
sis190_get_mac_addr_from_eeprom(pdev, dev);
if (reg & 0x00000001)
rc = sis190_get_mac_addr_from_apc(pdev, dev);
}
return rc;
}

static void sis190_set_speed_auto(struct net_device *dev)
Expand Down

0 comments on commit 563e0ae

Please sign in to comment.