Skip to content

Commit

Permalink
[PATCH] f71805f: Resource needs not be global
Browse files Browse the repository at this point in the history
The F71805F I/O resource structure needs not be a global variable,
as the platform core allocs its own copy of it anyway.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Jean Delvare authored and Greg Kroah-Hartman committed Jun 22, 2006
1 parent 59ac836 commit 568825c
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions drivers/hwmon/f71805f.c
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,6 @@ superio_exit(int base)
#define ADDR_REG_OFFSET 0
#define DATA_REG_OFFSET 1

static struct resource f71805f_resource __initdata = {
.flags = IORESOURCE_IO,
};

/*
* Registers
*/
Expand Down Expand Up @@ -782,6 +778,11 @@ static struct platform_driver f71805f_driver = {

static int __init f71805f_device_add(unsigned short address)
{
struct resource res = {
.start = address,
.end = address + REGION_LENGTH - 1,
.flags = IORESOURCE_IO,
};
int err;

pdev = platform_device_alloc(DRVNAME, address);
Expand All @@ -791,10 +792,8 @@ static int __init f71805f_device_add(unsigned short address)
goto exit;
}

f71805f_resource.start = address;
f71805f_resource.end = address + REGION_LENGTH - 1;
f71805f_resource.name = pdev->name;
err = platform_device_add_resources(pdev, &f71805f_resource, 1);
res.name = pdev->name;
err = platform_device_add_resources(pdev, &res, 1);
if (err) {
printk(KERN_ERR DRVNAME ": Device resource addition failed "
"(%d)\n", err);
Expand Down

0 comments on commit 568825c

Please sign in to comment.