Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 327996
b: refs/heads/master
c: 828de4f
h: refs/heads/master
v: v3
  • Loading branch information
Gao feng authored and David S. Miller committed Sep 19, 2012
1 parent 1fb2e69 commit 5694125
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 9 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 3fd91fb35847a8b3287f00970efc069de16df8b4
refs/heads/master: 828de4f6bf6e785f7b5497f8f7cfd4d4fbcfdb7e
28 changes: 20 additions & 8 deletions trunk/net/core/dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -959,18 +959,30 @@ int dev_alloc_name(struct net_device *dev, const char *name)
}
EXPORT_SYMBOL(dev_alloc_name);

static int dev_get_valid_name(struct net_device *dev, const char *name)
static int dev_alloc_name_ns(struct net *net,
struct net_device *dev,
const char *name)
{
struct net *net;
char buf[IFNAMSIZ];
int ret;

BUG_ON(!dev_net(dev));
net = dev_net(dev);
ret = __dev_alloc_name(net, name, buf);
if (ret >= 0)
strlcpy(dev->name, buf, IFNAMSIZ);
return ret;
}

static int dev_get_valid_name(struct net *net,
struct net_device *dev,
const char *name)
{
BUG_ON(!net);

if (!dev_valid_name(name))
return -EINVAL;

if (strchr(name, '%'))
return dev_alloc_name(dev, name);
return dev_alloc_name_ns(net, dev, name);
else if (__dev_get_by_name(net, name))
return -EEXIST;
else if (dev->name != name)
Expand Down Expand Up @@ -1006,7 +1018,7 @@ int dev_change_name(struct net_device *dev, const char *newname)

memcpy(oldname, dev->name, IFNAMSIZ);

err = dev_get_valid_name(dev, newname);
err = dev_get_valid_name(net, dev, newname);
if (err < 0)
return err;

Expand Down Expand Up @@ -5589,7 +5601,7 @@ int register_netdevice(struct net_device *dev)

dev->iflink = -1;

ret = dev_get_valid_name(dev, dev->name);
ret = dev_get_valid_name(net, dev, dev->name);
if (ret < 0)
goto out;

Expand Down Expand Up @@ -6233,7 +6245,7 @@ int dev_change_net_namespace(struct net_device *dev, struct net *net, const char
/* We get here if we can't use the current device name */
if (!pat)
goto out;
if (dev_get_valid_name(dev, pat) < 0)
if (dev_get_valid_name(net, dev, pat) < 0)
goto out;
}

Expand Down

0 comments on commit 5694125

Please sign in to comment.