Skip to content

Commit

Permalink
tpm: xen-tpmfront: Fix default durations
Browse files Browse the repository at this point in the history
All the default durations were being set to 10 minutes which is
way too long for the timeouts. Normal values for the longest
duration are around 5 mins, and short duration ar around .5s.

Further, these are just the default, tpm_get_timeouts will set
them to values from the TPM (or throw an error).

Just remove them.

Acked-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
  • Loading branch information
Jason Gunthorpe authored and Konrad Rzeszutek Wilk committed Sep 24, 2013
1 parent 6a6f6e7 commit 56be889
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions drivers/char/tpm/xen-tpmfront.c
Original file line number Diff line number Diff line change
Expand Up @@ -210,8 +210,6 @@ static struct attribute_group vtpm_attr_grp = {
.attrs = vtpm_attrs,
};

#define TPM_LONG_TIMEOUT (10 * 60 * HZ)

static const struct tpm_vendor_specific tpm_vtpm = {
.status = vtpm_status,
.recv = vtpm_recv,
Expand All @@ -224,11 +222,6 @@ static const struct tpm_vendor_specific tpm_vtpm = {
.miscdev = {
.fops = &vtpm_ops,
},
.duration = {
TPM_LONG_TIMEOUT,
TPM_LONG_TIMEOUT,
TPM_LONG_TIMEOUT,
},
};

static irqreturn_t tpmif_interrupt(int dummy, void *dev_id)
Expand Down

0 comments on commit 56be889

Please sign in to comment.