Skip to content

Commit

Permalink
[PATCH] Fix HWRNG built-in initcalls priority
Browse files Browse the repository at this point in the history
This changes all HWRNG driver initcalls to module_init().  We must probe
the RNGs after the major kernel subsystems are already up and running (like
PCI).

This fixes Bug 7730.
http://bugzilla.kernel.org/show_bug.cgi?id=7730

Signed-off-by: Michael Buesch <mb@bu3sch.de>
Cc: Jan Beulich <jbeulich@novell.com>
Cc: Jeff Garzik <jeff@garzik.org>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Michael Buesch authored and Linus Torvalds committed Jan 12, 2007
1 parent 9863be5 commit 56fb5fe
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion drivers/char/hw_random/amd-rng.c
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ static void __exit mod_exit(void)
hwrng_unregister(&amd_rng);
}

subsys_initcall(mod_init);
module_init(mod_init);
module_exit(mod_exit);

MODULE_AUTHOR("The Linux Kernel team");
Expand Down
2 changes: 1 addition & 1 deletion drivers/char/hw_random/geode-rng.c
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ static void __exit mod_exit(void)
iounmap(mem);
}

subsys_initcall(mod_init);
module_init(mod_init);
module_exit(mod_exit);

MODULE_DESCRIPTION("H/W RNG driver for AMD Geode LX CPUs");
Expand Down
2 changes: 1 addition & 1 deletion drivers/char/hw_random/intel-rng.c
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ static void __exit mod_exit(void)
iounmap(mem);
}

subsys_initcall(mod_init);
module_init(mod_init);
module_exit(mod_exit);

MODULE_DESCRIPTION("H/W RNG driver for Intel chipsets");
Expand Down
2 changes: 1 addition & 1 deletion drivers/char/hw_random/ixp4xx-rng.c
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ static void __exit ixp4xx_rng_exit(void)
iounmap(rng_base);
}

subsys_initcall(ixp4xx_rng_init);
module_init(ixp4xx_rng_init);
module_exit(ixp4xx_rng_exit);

MODULE_AUTHOR("Deepak Saxena <dsaxena@plexity.net>");
Expand Down
2 changes: 1 addition & 1 deletion drivers/char/hw_random/via-rng.c
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ static void __exit mod_exit(void)
hwrng_unregister(&via_rng);
}

subsys_initcall(mod_init);
module_init(mod_init);
module_exit(mod_exit);

MODULE_DESCRIPTION("H/W RNG driver for VIA chipsets");
Expand Down

0 comments on commit 56fb5fe

Please sign in to comment.