Skip to content

Commit

Permalink
igb: cleanup incorrect comment and set IP Checksum Enable
Browse files Browse the repository at this point in the history
IP Checksum enable doesn't need packet split in order to function.  It only
requires the use of advanced descriptors which the current igb driver does.
So we can enable it always without any issues.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Alexander Duyck authored and David S. Miller committed Feb 16, 2009
1 parent 1e5c3d2 commit 56fbbb4
Showing 1 changed file with 4 additions and 10 deletions.
14 changes: 4 additions & 10 deletions drivers/net/igb/igb_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2059,17 +2059,11 @@ static void igb_configure_rx(struct igb_adapter *adapter)
} else {
/* Enable Receive Checksum Offload for TCP and UDP */
rxcsum = rd32(E1000_RXCSUM);
if (adapter->rx_csum) {
rxcsum |= E1000_RXCSUM_TUOFL;
if (adapter->rx_csum)
rxcsum |= E1000_RXCSUM_TUOFL | E1000_RXCSUM_IPPCSE;
else
rxcsum &= ~(E1000_RXCSUM_TUOFL | E1000_RXCSUM_IPPCSE);

/* Enable IPv4 payload checksum for UDP fragments
* Must be used in conjunction with packet-split. */
if (adapter->rx_ps_hdr_size)
rxcsum |= E1000_RXCSUM_IPPCSE;
} else {
rxcsum &= ~E1000_RXCSUM_TUOFL;
/* don't need to clear IPPCSE as it defaults to 0 */
}
wr32(E1000_RXCSUM, rxcsum);
}

Expand Down

0 comments on commit 56fbbb4

Please sign in to comment.