Skip to content

Commit

Permalink
NFS: dont allow minorversion= opt when vers != 4
Browse files Browse the repository at this point in the history
Don't allow invalid 'vers' and 'minorversion' combinations in mount options,
such as "vers=3,minorversion=1".

Signed-off-by: Weston Andros Adamson <dros@netapp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
  • Loading branch information
Weston Andros Adamson authored and Trond Myklebust committed Feb 15, 2012
1 parent 2f09c24 commit 571b755
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions fs/nfs/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -1531,6 +1531,9 @@ static int nfs_parse_mount_options(char *raw,
if (!sloppy && invalid_option)
return 0;

if (mnt->minorversion && mnt->version != 4)
goto out_minorversion_mismatch;

/*
* verify that any proto=/mountproto= options match the address
* familiies in the addr=/mountaddr= options.
Expand Down Expand Up @@ -1564,6 +1567,10 @@ static int nfs_parse_mount_options(char *raw,
out_invalid_value:
printk(KERN_INFO "NFS: bad mount option value specified: %s\n", p);
return 0;
out_minorversion_mismatch:
printk(KERN_INFO "NFS: mount option vers=%u does not support "
"minorversion=%u\n", mnt->version, mnt->minorversion);
return 0;
out_nomem:
printk(KERN_INFO "NFS: not enough memory to parse option\n");
return 0;
Expand Down

0 comments on commit 571b755

Please sign in to comment.