Skip to content

Commit

Permalink
Input: mouse - use __maybe_unused instead of ifdef around suspend/resume
Browse files Browse the repository at this point in the history
Use __maybe_unused instead of ifdef guards around suspend/resume
functions, in order to increase build coverage and fix build warnings.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
  • Loading branch information
Jingoo Han authored and Dmitry Torokhov committed Nov 2, 2014
1 parent 97a652a commit 572081a
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 12 deletions.
6 changes: 2 additions & 4 deletions drivers/input/mouse/cyapa.c
Original file line number Diff line number Diff line change
Expand Up @@ -905,8 +905,7 @@ static int cyapa_remove(struct i2c_client *client)
return 0;
}

#ifdef CONFIG_PM_SLEEP
static int cyapa_suspend(struct device *dev)
static int __maybe_unused cyapa_suspend(struct device *dev)
{
int ret;
u8 power_mode;
Expand All @@ -929,7 +928,7 @@ static int cyapa_suspend(struct device *dev)
return 0;
}

static int cyapa_resume(struct device *dev)
static int __maybe_unused cyapa_resume(struct device *dev)
{
int ret;
struct cyapa *cyapa = dev_get_drvdata(dev);
Expand All @@ -944,7 +943,6 @@ static int cyapa_resume(struct device *dev)
enable_irq(cyapa->irq);
return 0;
}
#endif /* CONFIG_PM_SLEEP */

static SIMPLE_DEV_PM_OPS(cyapa_pm_ops, cyapa_suspend, cyapa_resume);

Expand Down
6 changes: 2 additions & 4 deletions drivers/input/mouse/navpoint.c
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,7 @@ static int navpoint_remove(struct platform_device *pdev)
return 0;
}

#ifdef CONFIG_PM_SLEEP
static int navpoint_suspend(struct device *dev)
static int __maybe_unused navpoint_suspend(struct device *dev)
{
struct platform_device *pdev = to_platform_device(dev);
struct navpoint *navpoint = platform_get_drvdata(pdev);
Expand All @@ -333,7 +332,7 @@ static int navpoint_suspend(struct device *dev)
return 0;
}

static int navpoint_resume(struct device *dev)
static int __maybe_unused navpoint_resume(struct device *dev)
{
struct platform_device *pdev = to_platform_device(dev);
struct navpoint *navpoint = platform_get_drvdata(pdev);
Expand All @@ -346,7 +345,6 @@ static int navpoint_resume(struct device *dev)

return 0;
}
#endif

static SIMPLE_DEV_PM_OPS(navpoint_pm_ops, navpoint_suspend, navpoint_resume);

Expand Down
6 changes: 2 additions & 4 deletions drivers/input/mouse/synaptics_i2c.c
Original file line number Diff line number Diff line change
Expand Up @@ -614,8 +614,7 @@ static int synaptics_i2c_remove(struct i2c_client *client)
return 0;
}

#ifdef CONFIG_PM_SLEEP
static int synaptics_i2c_suspend(struct device *dev)
static int __maybe_unused synaptics_i2c_suspend(struct device *dev)
{
struct i2c_client *client = to_i2c_client(dev);
struct synaptics_i2c *touch = i2c_get_clientdata(client);
Expand All @@ -628,7 +627,7 @@ static int synaptics_i2c_suspend(struct device *dev)
return 0;
}

static int synaptics_i2c_resume(struct device *dev)
static int __maybe_unused synaptics_i2c_resume(struct device *dev)
{
int ret;
struct i2c_client *client = to_i2c_client(dev);
Expand All @@ -643,7 +642,6 @@ static int synaptics_i2c_resume(struct device *dev)

return 0;
}
#endif

static SIMPLE_DEV_PM_OPS(synaptics_i2c_pm, synaptics_i2c_suspend,
synaptics_i2c_resume);
Expand Down

0 comments on commit 572081a

Please sign in to comment.