Skip to content

Commit

Permalink
e1000e: remove RXSEQ link monitoring for serdes
Browse files Browse the repository at this point in the history
RXSEQ interrupts were used to force link state interrogation of serdes
links, as the Si was not guaranteed to report LSC interrupts when the
link changed state. On some bladeservers this resulted in false link up
reports if no link partner was connected. The RXSEQ treatment is
not necessary, as the link can be monitored from the watchdog timer, and
the false link indications cease.

Signed-off-by: dave graham <david.graham@intel.com>
Acked-by: Bruce Allan <bruce.w.allan@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
dave graham authored and David S. Miller committed Feb 11, 2009
1 parent 5df3f0e commit 573cca8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/e1000e/netdev.c
Original file line number Diff line number Diff line change
Expand Up @@ -1153,7 +1153,7 @@ static irqreturn_t e1000_intr_msi(int irq, void *data)
* read ICR disables interrupts using IAM
*/

if (icr & (E1000_ICR_RXSEQ | E1000_ICR_LSC)) {
if (icr & E1000_ICR_LSC) {
hw->mac.get_link_status = 1;
/*
* ICH8 workaround-- Call gig speed drop workaround on cable
Expand Down Expand Up @@ -1219,7 +1219,7 @@ static irqreturn_t e1000_intr(int irq, void *data)
* IMC write
*/

if (icr & (E1000_ICR_RXSEQ | E1000_ICR_LSC)) {
if (icr & E1000_ICR_LSC) {
hw->mac.get_link_status = 1;
/*
* ICH8 workaround-- Call gig speed drop workaround on cable
Expand Down

0 comments on commit 573cca8

Please sign in to comment.