Skip to content

Commit

Permalink
phy: error handling for platform_device_register_simple()
Browse files Browse the repository at this point in the history
platform_device_register_simple() returns ERR_PTR() and not NULL.

Found by smatch (http://repo.or.cz/w/smatch.git).  Compile tested.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Dan Carpenter authored and David S. Miller committed Apr 11, 2009
1 parent 3384901 commit 57401d5
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions drivers/net/phy/fixed.c
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#include <linux/mii.h>
#include <linux/phy.h>
#include <linux/phy_fixed.h>
#include <linux/err.h>

#define MII_REGS_NUM 29

Expand Down Expand Up @@ -207,8 +208,8 @@ static int __init fixed_mdio_bus_init(void)
int ret;

pdev = platform_device_register_simple("Fixed MDIO bus", 0, NULL, 0);
if (!pdev) {
ret = -ENOMEM;
if (IS_ERR(pdev)) {
ret = PTR_ERR(pdev);
goto err_pdev;
}

Expand Down

0 comments on commit 57401d5

Please sign in to comment.