Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 316212
b: refs/heads/master
c: 571f6a7
h: refs/heads/master
v: v3
  • Loading branch information
Brian Austin authored and Mark Brown committed Jun 5, 2012
1 parent ef82fc1 commit 5747c75
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 16 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 165961efc03159631eadc086877704c7778ac356
refs/heads/master: 571f6a7f07e9dda6c9795398747278e52368c88a
20 changes: 5 additions & 15 deletions trunk/sound/soc/codecs/cs42l73.c
Original file line number Diff line number Diff line change
Expand Up @@ -1362,11 +1362,11 @@ static __devinit int cs42l73_i2c_probe(struct i2c_client *i2c_client,

i2c_set_clientdata(i2c_client, cs42l73);

cs42l73->regmap = regmap_init_i2c(i2c_client, &cs42l73_regmap);
cs42l73->regmap = devm_regmap_init_i2c(i2c_client, &cs42l73_regmap);
if (IS_ERR(cs42l73->regmap)) {
ret = PTR_ERR(cs42l73->regmap);
dev_err(&i2c_client->dev, "regmap_init() failed: %d\n", ret);
goto err;
return ret;
}
/* initialize codec */
ret = regmap_read(cs42l73->regmap, CS42L73_DEVID_AB, &reg);
Expand All @@ -1384,13 +1384,13 @@ static __devinit int cs42l73_i2c_probe(struct i2c_client *i2c_client,
dev_err(&i2c_client->dev,
"CS42L73 Device ID (%X). Expected %X\n",
devid, CS42L73_DEVID);
goto err_regmap;
return ret;
}

ret = regmap_read(cs42l73->regmap, CS42L73_REVID, &reg);
if (ret < 0) {
dev_err(&i2c_client->dev, "Get Revision ID failed\n");
goto err_regmap;
return ret;;
}

dev_info(&i2c_client->dev,
Expand All @@ -1402,23 +1402,13 @@ static __devinit int cs42l73_i2c_probe(struct i2c_client *i2c_client,
&soc_codec_dev_cs42l73, cs42l73_dai,
ARRAY_SIZE(cs42l73_dai));
if (ret < 0)
goto err_regmap;
return ret;
return 0;

err_regmap:
regmap_exit(cs42l73->regmap);

err:
return ret;
}

static __devexit int cs42l73_i2c_remove(struct i2c_client *client)
{
struct cs42l73_private *cs42l73 = i2c_get_clientdata(client);

snd_soc_unregister_codec(&client->dev);
regmap_exit(cs42l73->regmap);

return 0;
}

Expand Down

0 comments on commit 5747c75

Please sign in to comment.