Skip to content

Commit

Permalink
sched: remove set_leftmost()
Browse files Browse the repository at this point in the history
Lee Schermerhorn noticed that set_leftmost() contains dead code,
remove this.

Reported-by: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Ingo Molnar committed Oct 15, 2007
1 parent 2ddbf95 commit 57cb499
Showing 1 changed file with 2 additions and 12 deletions.
14 changes: 2 additions & 12 deletions kernel/sched_fair.c
Original file line number Diff line number Diff line change
Expand Up @@ -124,16 +124,6 @@ max_vruntime(u64 min_vruntime, u64 vruntime)
return min_vruntime;
}

static inline void
set_leftmost(struct cfs_rq *cfs_rq, struct rb_node *leftmost)
{
struct sched_entity *se;

cfs_rq->rb_leftmost = leftmost;
if (leftmost)
se = rb_entry(leftmost, struct sched_entity, run_node);
}

static inline s64
entity_key(struct cfs_rq *cfs_rq, struct sched_entity *se)
{
Expand Down Expand Up @@ -175,7 +165,7 @@ __enqueue_entity(struct cfs_rq *cfs_rq, struct sched_entity *se)
* used):
*/
if (leftmost)
set_leftmost(cfs_rq, &se->run_node);
cfs_rq->rb_leftmost = &se->run_node;

rb_link_node(&se->run_node, parent, link);
rb_insert_color(&se->run_node, &cfs_rq->tasks_timeline);
Expand All @@ -185,7 +175,7 @@ static void
__dequeue_entity(struct cfs_rq *cfs_rq, struct sched_entity *se)
{
if (cfs_rq->rb_leftmost == &se->run_node)
set_leftmost(cfs_rq, rb_next(&se->run_node));
cfs_rq->rb_leftmost = rb_next(&se->run_node);

rb_erase(&se->run_node, &cfs_rq->tasks_timeline);
}
Expand Down

0 comments on commit 57cb499

Please sign in to comment.