Skip to content

Commit

Permalink
[MMC] PXA and i.MX: don't avoid sending stop command on error
Browse files Browse the repository at this point in the history
Always send a stop command at the end of a data transfer.  If we avoid
sending the stop command, some cards remain in data transfer mode, and
refuse to accept further read/write commands.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Russell King authored and Russell King committed May 2, 2006
1 parent 37be4e7 commit 58741e8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion drivers/mmc/imxmmc.c
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ static int imxmci_data_done(struct imxmci_host *host, unsigned int stat)

data_error = imxmci_finish_data(host, stat);

if (host->req->stop && (data_error == MMC_ERR_NONE)) {
if (host->req->stop) {
imxmci_stop_clock(host);
imxmci_start_cmd(host, host->req->stop, 0);
} else {
Expand Down
2 changes: 1 addition & 1 deletion drivers/mmc/pxamci.c
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ static int pxamci_data_done(struct pxamci_host *host, unsigned int stat)
pxamci_disable_irq(host, DATA_TRAN_DONE);

host->data = NULL;
if (host->mrq->stop && data->error == MMC_ERR_NONE) {
if (host->mrq->stop) {
pxamci_stop_clock(host);
pxamci_start_cmd(host, host->mrq->stop, 0);
} else {
Expand Down

0 comments on commit 58741e8

Please sign in to comment.