Skip to content

Commit

Permalink
[PATCH] do __unhash_process() under ->siglock
Browse files Browse the repository at this point in the history
This patch moves __unhash_process() call from realease_task() to
__exit_signal(), so __detach_pid() is called with ->siglock held.

This means we don't need tasklist_lock to iterate over thread group anymore:

	copy_process() was already changed to do attach_pid()
	under ->siglock.

	Eric's "pidhash-kill-switch_exec_pids.patch" from -mm
	changed de_thread() so it doesn't touch PIDTYPE_TGID.

NOTE: de_thread() still needs some attention.  It still changes task->pid
lockless.  Taking ->sighand.siglock here allows to do more tasklist_lock
removals.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Oleg Nesterov authored and Linus Torvalds committed Mar 29, 2006
1 parent 35f5cad commit 5876700
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions kernel/exit.c
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,8 @@ static void __exit_signal(struct task_struct *tsk)
sig = NULL; /* Marker for below. */
}

__unhash_process(tsk);

tsk->signal = NULL;
cleanup_sighand(tsk);
spin_unlock(&sighand->siglock);
Expand Down Expand Up @@ -140,8 +142,6 @@ void release_task(struct task_struct * p)
BUG_ON(!list_empty(&p->ptrace_list) || !list_empty(&p->ptrace_children));
__exit_signal(p);

__unhash_process(p);

/*
* If we are the last non-leader member of the thread
* group, and the leader is zombie, then notify the
Expand Down

0 comments on commit 5876700

Please sign in to comment.