Skip to content

Commit

Permalink
V4L/DVB (6215): Bugfix for saa6588.c, add forgotten spin_lock_init()
Browse files Browse the repository at this point in the history
There's a serious bug in saa6588.c, it uses a non-initialized spin_lock.
Funny thing is that it works fine with bttv, but completly freezes the
machine if e.g. saa7134 is loaded.

Thanks to Derek Philip for reporting this bug on the rdsd-devel list.

This patch adds the missing spin_lock_init().

Signed-off-by: Hans J. Koch <hjk@linutronix.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
  • Loading branch information
Hans-Jürgen Koch authored and Mauro Carvalho Chehab committed Oct 10, 2007
1 parent 39f46ad commit 588005e
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/media/video/saa6588.c
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,7 @@ static int saa6588_attach(struct i2c_adapter *adap, int addr, int kind)
kfree(s);
return -ENOMEM;
}
spin_lock_init(&s->lock);
s->client = client_template;
s->block_count = 0;
s->wr_index = 0;
Expand Down

0 comments on commit 588005e

Please sign in to comment.