Skip to content

Commit

Permalink
kbuild: fix format string warnings in modpost
Browse files Browse the repository at this point in the history
Fix wrong format strings in modpost exposed by the previous patch.
Including one missing argument -- some random data was printed instead.
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
  • Loading branch information
Andi Kleen authored and Sam Ravnborg committed Jan 28, 2008
1 parent 6d9a89e commit 58b7a68
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions scripts/mod/modpost.c
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ static int parse_elf(struct elf_info *info, const char *filename)

/* Check if file offset is correct */
if (hdr->e_shoff > info->size) {
fatal("section header offset=%u in file '%s' is bigger then filesize=%lu\n", hdr->e_shoff, filename, info->size);
fatal("section header offset=%lu in file '%s' is bigger then filesize=%lu\n", (unsigned long)hdr->e_shoff, filename, info->size);
return 0;
}

Expand All @@ -409,7 +409,7 @@ static int parse_elf(struct elf_info *info, const char *filename)
const char *secname;

if (sechdrs[i].sh_offset > info->size) {
fatal("%s is truncated. sechdrs[i].sh_offset=%u > sizeof(*hrd)=%ul\n", filename, (unsigned int)sechdrs[i].sh_offset, sizeof(*hdr));
fatal("%s is truncated. sechdrs[i].sh_offset=%lu > sizeof(*hrd)=%lu\n", filename, (unsigned long)sechdrs[i].sh_offset, sizeof(*hdr));
return 0;
}
secname = secstrings + sechdrs[i].sh_name;
Expand Down Expand Up @@ -907,7 +907,8 @@ static void warn_sec_mismatch(const char *modname, const char *fromsec,
"before '%s' (at offset -0x%llx)\n",
modname, fromsec, (unsigned long long)r.r_offset,
secname, refsymname,
elf->strtab + after->st_name);
elf->strtab + after->st_name,
(unsigned long long)r.r_offset);
} else {
warn("%s(%s+0x%llx): Section mismatch: reference to %s:%s\n",
modname, fromsec, (unsigned long long)r.r_offset,
Expand Down

0 comments on commit 58b7a68

Please sign in to comment.