Skip to content

Commit

Permalink
spi/sc18is602: Return -EINVAL for probe failures due to I2C function …
Browse files Browse the repository at this point in the history
…mismatch

If the I2C bus master driver does not support the required functionality,
the driver returns -ENODEV. This causes a silent probe failure without error
message. Since the device has to be explicitly instantiated, and the user
should know the correct bus, this event really reflects an error condition.
Replace error return value with -EINVAL to trigger an error message showing
that the probe function failed.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
  • Loading branch information
Guenter Roeck authored and Mark Brown committed Aug 23, 2012
1 parent 41962f9 commit 58ed90d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/spi/spi-sc18is602.c
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ static int sc18is602_probe(struct i2c_client *client,

if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C |
I2C_FUNC_SMBUS_WRITE_BYTE_DATA))
return -ENODEV;
return -EINVAL;

master = spi_alloc_master(dev, sizeof(struct sc18is602));
if (!master)
Expand Down

0 comments on commit 58ed90d

Please sign in to comment.