Skip to content

Commit

Permalink
[NET]: Can use __get_cpu_var() instead of per_cpu() in loopback driver.
Browse files Browse the repository at this point in the history
As BHs are off in loopback_xmit(), preemption cannot occurs, so we can
use __get_cpu_var() instead of per_cpu() (and avoid a
preempt_enable()/preempt_disable() pair)

Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Eric Dumazet authored and David S. Miller committed Oct 20, 2006
1 parent 78d7942 commit 58f5397
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/net/loopback.c
Original file line number Diff line number Diff line change
Expand Up @@ -153,14 +153,14 @@ static int loopback_xmit(struct sk_buff *skb, struct net_device *dev)
#endif
dev->last_rx = jiffies;

lb_stats = &per_cpu(pcpu_lstats, get_cpu());
/* it's OK to use __get_cpu_var() because BHs are off */
lb_stats = &__get_cpu_var(pcpu_lstats);
lb_stats->bytes += skb->len;
lb_stats->packets++;
put_cpu();

netif_rx(skb);

return(0);
return 0;
}

static struct net_device_stats loopback_stats;
Expand Down

0 comments on commit 58f5397

Please sign in to comment.