Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 157419
b: refs/heads/master
c: 179a810
h: refs/heads/master
i:
  157417: e22541b
  157415: 8bc9db7
v: v3
  • Loading branch information
Catalin Marinas committed Sep 8, 2009
1 parent 226206b commit 591bd82
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 18 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 43ed5d6ee0f9bfd655d6bc3cb2d964b80c4422c0
refs/heads/master: 179a8100e12d0053f4b368ea3358dd9a0fc6cb94
22 changes: 5 additions & 17 deletions trunk/mm/kmemleak.c
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@
#include <linux/string.h>
#include <linux/nodemask.h>
#include <linux/mm.h>
#include <linux/workqueue.h>

#include <asm/sections.h>
#include <asm/processor.h>
Expand Down Expand Up @@ -1499,7 +1500,7 @@ static const struct file_operations kmemleak_fops = {
* Perform the freeing of the kmemleak internal objects after waiting for any
* current memory scan to complete.
*/
static int kmemleak_cleanup_thread(void *arg)
static void kmemleak_do_cleanup(struct work_struct *work)
{
struct kmemleak_object *object;

Expand All @@ -1511,22 +1512,9 @@ static int kmemleak_cleanup_thread(void *arg)
delete_object_full(object->pointer);
rcu_read_unlock();
mutex_unlock(&scan_mutex);

return 0;
}

/*
* Start the clean-up thread.
*/
static void kmemleak_cleanup(void)
{
struct task_struct *cleanup_thread;

cleanup_thread = kthread_run(kmemleak_cleanup_thread, NULL,
"kmemleak-clean");
if (IS_ERR(cleanup_thread))
pr_warning("Failed to create the clean-up thread\n");
}
static DECLARE_WORK(cleanup_work, kmemleak_do_cleanup);

/*
* Disable kmemleak. No memory allocation/freeing will be traced once this
Expand All @@ -1544,7 +1532,7 @@ static void kmemleak_disable(void)

/* check whether it is too early for a kernel thread */
if (atomic_read(&kmemleak_initialized))
kmemleak_cleanup();
schedule_work(&cleanup_work);

pr_info("Kernel memory leak detector disabled\n");
}
Expand Down Expand Up @@ -1640,7 +1628,7 @@ static int __init kmemleak_late_init(void)
* after setting kmemleak_initialized and we may end up with
* two clean-up threads but serialized by scan_mutex.
*/
kmemleak_cleanup();
schedule_work(&cleanup_work);
return -ENOMEM;
}

Expand Down

0 comments on commit 591bd82

Please sign in to comment.