Skip to content

Commit

Permalink
module: cleanup FIXME comments about trimming exception table entries.
Browse files Browse the repository at this point in the history
Everyone cut and paste this comment from my original one.  We now do
it generically, so cut the comments.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Cc: Amerigo Wang <amwang@redhat.com>
  • Loading branch information
Rusty Russell committed Jun 12, 2009
1 parent ad6561d commit 5933048
Show file tree
Hide file tree
Showing 16 changed files with 0 additions and 32 deletions.
2 changes: 0 additions & 2 deletions arch/avr32/kernel/module.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ void module_free(struct module *mod, void *module_region)
mod->arch.syminfo = NULL;

vfree(module_region);
/* FIXME: if module_region == mod->init_region, trim exception
* table entries. */
}

static inline int check_rela(Elf32_Rela *rela, struct module *module,
Expand Down
2 changes: 0 additions & 2 deletions arch/cris/kernel/module.c
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ void *module_alloc(unsigned long size)
void module_free(struct module *mod, void *module_region)
{
FREE_MODULE(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
table entries. */
}

/* We don't need anything special. */
Expand Down
2 changes: 0 additions & 2 deletions arch/frv/kernel/module.c
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ void *module_alloc(unsigned long size)
void module_free(struct module *mod, void *module_region)
{
vfree(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
table entries. */
}

/* We don't need anything special. */
Expand Down
2 changes: 0 additions & 2 deletions arch/h8300/kernel/module.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ void *module_alloc(unsigned long size)
void module_free(struct module *mod, void *module_region)
{
vfree(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
table entries. */
}

/* We don't need anything special. */
Expand Down
2 changes: 0 additions & 2 deletions arch/m32r/kernel/module.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ void *module_alloc(unsigned long size)
void module_free(struct module *mod, void *module_region)
{
vfree(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
table entries. */
}

/* We don't need anything special. */
Expand Down
2 changes: 0 additions & 2 deletions arch/m68k/kernel/module.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ void *module_alloc(unsigned long size)
void module_free(struct module *mod, void *module_region)
{
vfree(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
table entries. */
}

/* We don't need anything special. */
Expand Down
2 changes: 0 additions & 2 deletions arch/m68knommu/kernel/module.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ void *module_alloc(unsigned long size)
void module_free(struct module *mod, void *module_region)
{
vfree(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
table entries. */
}

/* We don't need anything special. */
Expand Down
2 changes: 0 additions & 2 deletions arch/mips/kernel/module.c
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,6 @@ void *module_alloc(unsigned long size)
void module_free(struct module *mod, void *module_region)
{
vfree(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
table entries. */
}

int module_frob_arch_sections(Elf_Ehdr *hdr, Elf_Shdr *sechdrs,
Expand Down
2 changes: 0 additions & 2 deletions arch/mn10300/kernel/module.c
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ void *module_alloc(unsigned long size)
void module_free(struct module *mod, void *module_region)
{
vfree(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
* table entries. */
}

/*
Expand Down
2 changes: 0 additions & 2 deletions arch/parisc/kernel/module.c
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,6 @@ void module_free(struct module *mod, void *module_region)
mod->arch.section = NULL;

vfree(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
table entries. */
}

/* Additional bytes needed in front of individual sections */
Expand Down
2 changes: 0 additions & 2 deletions arch/powerpc/kernel/module.c
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ void *module_alloc(unsigned long size)
void module_free(struct module *mod, void *module_region)
{
vfree(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
table entries. */
}

static const Elf_Shdr *find_section(const Elf_Ehdr *hdr,
Expand Down
2 changes: 0 additions & 2 deletions arch/s390/kernel/module.c
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,6 @@ void *module_alloc(unsigned long size)
void module_free(struct module *mod, void *module_region)
{
vfree(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
table entries. */
}

static void
Expand Down
2 changes: 0 additions & 2 deletions arch/sh/kernel/module.c
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@ void *module_alloc(unsigned long size)
void module_free(struct module *mod, void *module_region)
{
vfree(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
table entries. */
}

/* We don't need anything special. */
Expand Down
2 changes: 0 additions & 2 deletions arch/sparc/kernel/module.c
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,6 @@ void *module_alloc(unsigned long size)
void module_free(struct module *mod, void *module_region)
{
vfree(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
table entries. */
}

/* Make generic code ignore STT_REGISTER dummy undefined symbols. */
Expand Down
2 changes: 0 additions & 2 deletions arch/x86/kernel/module.c
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,6 @@ void *module_alloc(unsigned long size)
void module_free(struct module *mod, void *module_region)
{
vfree(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
table entries. */
}

/* We don't need anything special. */
Expand Down
2 changes: 0 additions & 2 deletions arch/xtensa/kernel/module.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ void *module_alloc(unsigned long size)
void module_free(struct module *mod, void *module_region)
{
vfree(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
table entries. */
}

int module_frob_arch_sections(Elf32_Ehdr *hdr,
Expand Down

0 comments on commit 5933048

Please sign in to comment.