Skip to content

Commit

Permalink
Staging: wlan-ng: silence a sparse warning
Browse files Browse the repository at this point in the history
This doesn't change the behavior.  It just silences a sparse warning.

drivers/staging/wlan-ng/hfa384x_usb.c:2810:62: warning: dubious: !x | !y

The point of the bitwise OR is so that a logical OR could short circuit
the second call to test_and_set_bit().

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Dan Carpenter authored and Greg Kroah-Hartman committed Jun 18, 2010
1 parent 25ebc2f commit 5945789
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions drivers/staging/wlan-ng/hfa384x_usb.c
Original file line number Diff line number Diff line change
Expand Up @@ -2805,11 +2805,13 @@ void hfa384x_tx_timeout(wlandevice_t *wlandev)

spin_lock_irqsave(&hw->ctlxq.lock, flags);

if (!hw->wlandev->hwremoved &&
/* Note the bitwise OR, not the logical OR. */
(!test_and_set_bit(WORK_TX_HALT, &hw->usb_flags) |
!test_and_set_bit(WORK_RX_HALT, &hw->usb_flags))) {
schedule_work(&hw->usb_work);
if (!hw->wlandev->hwremoved) {
int sched;

sched = !test_and_set_bit(WORK_TX_HALT, &hw->usb_flags);
sched |= !test_and_set_bit(WORK_RX_HALT, &hw->usb_flags);
if (sched)
schedule_work(&hw->usb_work);
}

spin_unlock_irqrestore(&hw->ctlxq.lock, flags);
Expand Down

0 comments on commit 5945789

Please sign in to comment.